Thegreatsuspender: Dark mode unsuspending

[lookfirst]

Please complete the following information when submitting a feature request or bug report.

• Extension version:

7.0.109

• Browser name & version:

Version 73.0.3683.103 (Official Build) (64-bit)

• Operating system & version:

OSX 10.14.4

---

I'm running in dark mode.

When unsuspending a window, the window flashes white. I see the same behavior during the suspension phase using the command keys to turn on suspension.

Looking at the source code it is because it switches to the restoring-window.html file, which does not have the dark mode CSS treatment.

Changing this doesn't look too complicated, except I'd probably clean up the code a bit to simplify things and prevent this issue from happening in the future. Switching between files like that doesn't seem necessary.

[deanoemcke]

It does not actually use restoring-window.html. It is only ever using suspended.html. The cause of the flash is because the dark theme css isn't applied until the theme setting can be read on the page via javascript. It could be swapped around so that by default the page is dark, but this would cause an opposite flash of black when using the light theme.

Not sure why you are getting a flash of white when unsuspending via hotkeys. There should be no flash in this instance. Although unsuspending via refresh (or F5) will also cause this flash. Once again, this is because whenever the suspended.html file is first loaded it has a white background before the dark theme can be applied.

If you have a suggestion for how to get around this, I'd love to hear your ideas. The only thing I can think of is to have two separate html pages, one for each theme. But I don't want to do this as it will add a lot more complexity to the extension.

[lookfirst]

Hi @deanoemcke, you're right, of course. Sorry for miss diagnosing the issue. =) Also, it is refresh the page that causes the issue for me.

Can you try:

body:not(.loaded) {
display:none;
}

Then add the class. It might show up as the 'default' background color that way.

Probably generating separate pages is best, but agreed... not ideal. That said, it can be pretty easily added to the build output.

[JonnyRedHed]

I see this as well.

I also get some odd half or quarter drop down menu when clicking quick the icon on the extensions bar. Opera (stable latest). Been happening for this version and last one. Can't really replicate it, but a few times a day it doesn't show the drop down so I have to click again.

Also there appears to be a thick white border around the top, bottom and right side of the drop down menu. Is this by design or a bug. Again Opera latest running dark mode UI.