Thanos: receive,ruler: Potentially leaking disk from TSDB Mmap-ed chunks.
Introduced on master by: https://github.com/thanos-io/thanos/pull/2658 (0.13 is fine)
Tracking ticket on Prometheus https://github.com/prometheus/prometheus/issues/7305
bwplotka
All 5 comments
Affected from https://github.com/thanos-io/thanos/commit/f7802edbf8306c07cc51435425d8f61b7fb94716 commit.
bwplotka
on 28 May 2020
Fixed in https://github.com/prometheus/prometheus/pull/7306, I will open a PR for Prometheus upgrade tomorrow. And I think it should go against release branch and even the latest Prometheus upgrade which happened in master should go in 0.13 because the old upgrade does not include fix to the memory leak in isolation which is there in latest upgrade (found it yesterday).
codesome
on 28 May 2020
Hmmm, ok.
Let's do serparate updates for release and master then.
bwplotka
on 28 May 2020
Let's not put too much on release-0.13 to reduce risk
bwplotka
on 28 May 2020
https://github.com/thanos-io/thanos/pull/2697 for isolation fix on 0.13.0
bwplotka
on 1 Jun 2020
Related issues
rmrf
路
4Comments
bwplotka
路
4Comments
asudhakarreddy
路
3Comments
MrD2
路
3Comments
wiardvanrij
路
3Comments
Most helpful comment
Fixed in https://github.com/prometheus/prometheus/pull/7306, I will open a PR for Prometheus upgrade tomorrow. And I think it should go against release branch and even the latest Prometheus upgrade which happened in master should go in 0.13 because the old upgrade does not include fix to the memory leak in isolation which is there in latest upgrade (found it yesterday).