Thanos: Include DCO instructions in Contributing Guide

Created on 17 Apr 2020  Â·  3Comments  Â·  Source: thanos-io/thanos

While PRs are subject to a DCO signoff procedure (since #1388), this is not included in the Contributing Guide.

It looks like it should be a part of the steps provided in https://github.com/thanos-io/thanos/blob/master/CONTRIBUTING.md#pull-request-process but there may be other places it makes sense.

A great solution to this issue would include:

  • actual command to run to sign off on commit changes
  • explanation of what this means to the project
  • a link to more information from the CNCF
websitdocs good first issue help wanted

All 3 comments

Definitely :+1:

Help wanted! :hugs:

I am a newbie to Thanos. I would like to have a go at this.

Go for it!

On Sat, 18 Apr 2020 at 11:16, Ranjith Kumar notifications@github.com
wrote:

I am a newbie to Thanos. I would like to have a go at this.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/thanos-io/thanos/issues/2458#issuecomment-615836912,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABVA3O7KJXGIQMFV3Y47E4LRNF4Y3ANCNFSM4MK5HEGQ
.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

sevagh picture sevagh  Â·  3Comments

hedeesaa picture hedeesaa  Â·  3Comments

abursavich picture abursavich  Â·  4Comments

bwplotka picture bwplotka  Â·  4Comments

rmrf picture rmrf  Â·  4Comments