It would be awesome to learn if we need more concurrency etc there.
Those filters are critical for our components to learn about new blocks.
Are we primarily talking about benchmarking the Filter functions?
That's correct, but maybe only for more complex ones. E.g like https://github.com/thanos-io/thanos/pull/2118
I no longer work on this, so feel free to grab this and finish :hugs:
Great. I'll take it!
Awesome. Might be good to sync with @khyatisoneji, but she is busy recently so I am pretty sure she will be happy for you to continue benchmarking. (:
Feel free to checkout my branch and get all changes, then work on top of it (:
Hey @bwplotka! I was wondering if this issue is not picked up yet, can I solve this issue? I will try and understand the requirements of this issue, before pushing in a PR!
Of crouse, go for it @yashrsharma44 if @grzkv is not active :+1:
You can see the https://github.com/thanos-io/thanos/pull/2118 for some start.
@bwplotka @yashrsharma44 Sorry, I am short on time at least until the end of this week. Please feel free to pick it up.
Hello 馃憢 Looks like there was no activity on this issue for last 30 days.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 馃
If there will be no activity for next week, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.
Closing for now as promised, let us know if you need this to be reopened! 馃