Thanos: e2e: Add back removed e2e tests; Add ability to connect to certain host services from docker network

[bwplotka]

See: https://github.com/thanos-io/thanos/pull/2138#discussion_r382133169 && https://github.com/thanos-io/thanos/pull/2138#discussion_r382136126

[stale[bot]]

This issue/PR has been automatically marked as stale because it has not had recent activity. Please comment on status otherwise the issue will be closed in a week. Thank you for your contributions.

[bwplotka]

Still valid

[ranjithkumar007]

Hi, I would like to have a go at this.
We need to remove t.Skip() from 1 and add back the tests which used to be in TestRulePartialResponse right?

[bwplotka]

Yes!

On Sun, 19 Apr 2020 at 12:44, Ranjith Kumar [e-mail]
wrote:

Hi, I would like to have a go at this.
We need to remove t.Skip() from 1
https://github.com/thanos-io/thanos/blob/2262f2601a2b04d0be7a951d1d962e698520c44e/test/e2e/rule_test.go#L180
and add back the tests
https://github.com/thanos-io/thanos/pull/2138#discussion_r382136126
which used to be in TestRulePartialResponse right?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/thanos-io/thanos/issues/2164#issuecomment-616112751,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABVA3O7HHIWV56ERW3DTDXLRNLPY7ANCNFSM4KZCLXZQ
.

[ranjithkumar007]

Thanks @bwplotka .

[stale[bot]]

Hello 👋 Looks like there was no activity on this issue for last 30 days.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity for next week, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[bwplotka]

ping

On Wed, 20 May 2020 at 13:45, stale[bot] [e-mail] wrote:

Hello 👋 Looks like there was no activity on this issue for last 30 days.
Do you mind updating us on the status? Is this still reproducible or
needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity for next week, this issue will be closed (we
can always reopen an issue if we need!). Alternatively, use remind command
https://probot.github.io/apps/reminders/ if you wish to be reminded at
some point in future.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/thanos-io/thanos/issues/2164#issuecomment-631450471,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABVA3O4YNV4SHMVWDEH5HJTRSPGGTANCNFSM4KZCLXZQ
.

[ranjithkumar007]

@bwplotka didn't get much time to have a look at this. Will try to do this weekend.

[stale[bot]]

Hello 👋 Looks like there was no activity on this issue for last 30 days.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity for next week, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[stale[bot]]

Closing for now as promised, let us know if you need this to be reopened! 🤗