Text: Ability to insert images from local device (or link)

[jancborchardt]

It would be nice if it’s possible to also insert images from the local device into the document. For example:

• The image icon shows a popover having 2 options: "Image from Nextcloud" and "Image from device"
• "Image from Nextcloud" shows the current picker"
• "Image from device" shows a native file picker
• The image is uploaded in the background – we have to probably decide where to. We shouldn’t necessarily make the same mistake as in Talk and dump it into the root folder – maybe it doesn’t even need to be visible at all?

And as @juliushaertl said about remote images:

We cannot add remote images in general because they are blocked by the CSP as mentioned in the error. So for now only images from the same domain work for that.

@rullzer Does it make sense to to fetch remote images and deliver them from the local domain, similar to the proxy we have for the app store images? Or should we just block remote images for security reasons.

[juliushaertl]

The image is uploaded in the background – we have to probably decide where to. We shouldn’t necessarily make the same mistake as in Talk and dump it into the root folder – maybe it doesn’t even need to be visible at all?

If we are fine with not having them in the users file system, we can just drop them into app data and use them when needed.

[jancborchardt]

If we are fine with not having them in the users file system, we can just drop them into app data and use them when needed.

:+1: I’d say that’s really preferable since yeah – you know about the issue we have with Talk, where if you post an image in a chat, it is shared with every participant and then everyone’s root directory is full of trash.

So while people might ask for this in the future – having all the images also shared with each other – the default should not be that as we saw that it’s not working nicely. Also, you can easily work around it by simply creating a shared folder and putting everything in there.

[brainchild0]

I would tend to think that the most useful approach is to ingest the images into the file tree that would synchronize along with the document. Perhaps the application can create a subfolder, in the same directory as the document, for resource dependencies.

It also seems like the current approach for inserting server images, of pointing to a server URL, will cause users to struggle with broken references, because of removed resources and the inability to use on a client or to distribute from the files copied to a client. Again, keeping everything local seems to be the best option. Could the application write a local hard link to the external resource, or would doing so break existing design constraints for managing and synchronizing files?