Text: Name input should not be mandatory step to join share

[jancborchardt]

When joining a share link I’m faced with this:

Feels quite intrusive and strange. If I got the link it’s also fine to join as a guest and then set the name. This puts a barrier between people just quickly checking out the document and should not be there.

[jancborchardt]

Also, it even asks for your name when the link is read-only, so changing to bug.

[jancborchardt]

And more: When you refresh the link, it asks you for your name again. Should just remember that. :)

[skjnldsv]

What abou ta random funny name like google doc is doing?
SneakyRacoon :)

[juliushaertl]

Yes, that should be improved.

• [x] Add endpoint to update the guest name
• [x] Check if changing guest name is properly propagated to existing sessions
• [x] Allow to change the name in the frontend
• [x] Generate random names by default

[jancborchardt]

What abou ta random funny name like google doc is doing?
SneakyRacoon :)

Haha, sure :D But let’s do fruit & veggie names (maybe without adjective) then so it’s a bit different?

[skjnldsv]

TemptingEggplant? :grin:

[jancborchardt]

http://vegetablesfruitsgrains.com/list-of-vegetables/ – helpful ;)

[skjnldsv]

Oh man I love this already!!
Relevant library: https://github.com/adzialocha/random-animal-name-generator

[jancborchardt]

Oooooh even better and not English-centric:
https://github.com/SaraVieira/randomoji – npm package at https://www.npmjs.com/package/randomoji

[skjnldsv]

The idea of being non english centric is nice, but unfortunately emoji area bit confusing as names I think :thinking:

We could have a small amount of adjective and vegetable and make them translatable?

[jancborchardt]

Sure – but let’s not overthink this in general. ;) We can always do it step by step.

The important part is that joining a Text share shouldn’t have this blocking screen.

[juliushaertl]

Implemented with d392585