Text: Some link popover issues

Created on 13 Jun 2019  路  4Comments  路  Source: nextcloud/text

The link popover is not centered above the text, has grey highlight and white border around it (could just be white) and could use a triangle on the bottom to point to the text. (Also, if it鈥檚 just inserting the link, we can add text "Insert link"):
link popover not centered and has some stuff around it

The next step should be centered too, triangle too, and could also still highlight the selected word? Also, when you put in something without https:// or http://, it should be automatically prepended:
popover not centered and doesn鈥檛 highlight word and doesnt have a triangle

design enhancement

All 4 comments

Centering is already fixed on master.

The next step should be centered too, triangle too, and could also still highlight the selected word? Also, when you put in something without https:// or http://, it should be automatically prepended.

Should we always prepend https here? Note this might cause issues if the linked server doesn't have https support, the link would be broken. But the same might also happen the other way round, so I'd argue to just go with https

  • [x] Link editing bubble out of place when scrolled in the document

Should we always prepend https here? Note this might cause issues if the linked server doesn't have https support, the link would be broken. But the same might also happen the other way round, so I'd argue to just go with https

Yup, let鈥檚 just go with that for now. Rather err on the side of s. :D

Fixed with b51c857 and ecdc251

Was this page helpful?
0 / 5 - 0 ratings

Related issues

juliushaertl picture juliushaertl  路  3Comments

skoobasteeve picture skoobasteeve  路  4Comments

jancborchardt picture jancborchardt  路  6Comments

tobiasKaminsky picture tobiasKaminsky  路  4Comments

jancborchardt picture jancborchardt  路  3Comments