Test-infra: PR author becomes the bot when it's merged
What happened:
For Knative projects, started from around 10AM PST. on Mar. 4th 2020, all PR authors became the knative-prow-robot, as shown in https://github.com/knative/serving/commits/master.
The PR author for Istio also changed to the bot, see https://github.com/istio/istio.io/commits/master.
What you expected to happen:
The PR author should still be the one who created the PR.
Anything else we need to know?:
This should be due to an API change in Github, but I wonder if the fix can be made in Tide.
/help
/area prow/tide
chizhg
All 8 comments
@chizhg:
This request has been marked as needing help from a contributor.
Please ensure the request meets the requirements listed here.
If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.
In response to this:
What happened:
For Knative projects, started from around 10AM PST. on Mar. 4th 2020, all PR authors became the knative-prow-robot, as shown in https://github.com/knative/serving/commits/master.The PR author for Istio also changed to the bot, see https://github.com/istio/istio.io/commits/master.
What you expected to happen:
The PR author should still be the one who created the PR.Anything else we need to know?:
This should be due to an API change in Github, but I wonder if we can make the fix in Tide./help
/area prow/tide
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
k8s-ci-robot
on 4 Mar 2020
The problem is apparently GitHub platform-wide and specific to squash merging.
e.g.
clarketm
on 5 Mar 2020
This behavior doesn't make any sense and is IMHO a github bug. Merging something doesn't make the merging account the author of the change.
alvaroaleman
on 5 Mar 2020
This is really annoying. I think its a github bug.. look at https://github.com/envoyproxy/envoy/commits/master, thats not even a robot its just someone pressing "merge" on github and its accredited to him. I sent a ticket to github, not sure if it will change anything
howardjohn
on 5 Mar 2020
dims
on 5 Mar 2020
Until GitHub fixes this bug, orgs/repos using Prow can follow this pattern in Tide as mitigation. https://github.com/istio/test-infra/pull/2464
clarketm
on 5 Mar 2020
GH reverted the change. https://github.community/t5/How-to-use-Git-and-GitHub/Authorship-of-merge-commits-made-by-Github-Apps-changed/td-p/48797/page/2
/close
clarketm
on 6 Mar 2020
@clarketm: Closing this issue.
In response to this:
GH reverted the change. https://github.community/t5/How-to-use-Git-and-GitHub/Authorship-of-merge-commits-made-by-Github-Apps-changed/td-p/48797/page/2
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
k8s-ci-robot
on 6 Mar 2020
Related issues
fen4o
路
4Comments
MrHohn
路
4Comments
xiangpengzhao
路
3Comments
sjenning
路
4Comments
stevekuznetsov
路
4Comments
Most helpful comment
This is really annoying. I think its a github bug.. look at https://github.com/envoyproxy/envoy/commits/master, thats not even a robot its just someone pressing "merge" on github and its accredited to him. I sent a ticket to github, not sure if it will change anything