Test-infra: Allow association of periodic jobs with a repository

Created on 5 Oct 2019 · 13Comments · Source: kubernetes/test-infra

What would you like to be added:
I believe this should be added so in the UI you can sort by repo and see all the periodic jobs that are associated with said repo. Otherwise you have to specifically search for the job name.

This could be done by having a label that Prow looks at specifically. e.g.

label:
    repo: 'my-repo'

Why is this needed:
Better per-repo health checks at a glance.
Better organization if Prow is split amongst teams.

kinfeature lifecyclrotten

Source

Noremac201

❤1

Most helpful comment

IMHO the extra_refs stuff is a hack and we should create a ref-driven periodic type that explicitly opts into being part of a repo

stevekuznetsov on 7 Oct 2019

👍2 👀1

All 13 comments

Right now we loosely support this by setting extra_refs but not in Deck.
/cc @cjwagner @fejta @Katharine

stevekuznetsov on 7 Oct 2019

IMHO the extra_refs stuff is a hack and we should create a ref-driven periodic type that explicitly opts into being part of a repo

stevekuznetsov on 7 Oct 2019

👍2 👀1

IMHO the extra_refs stuff is a hack and we should create a ref-driven periodic type that explicitly opts into being part of a repo

WDYT about if a job has no refs but does have extraRefs, to change the logic to put extraRefs[0] in refs and strip it from extra_refs?

alvaroaleman on 22 Oct 2019

I would be interested in allowing people to group together related periodics. It would be useful to hand sig-foo a URL that says "here are all your sig-foo jobs".

This will most likely span repos, so I'm not sure that requiring periodics to pin to a repo is the right solution here.

fejta on 23 Oct 2019

👍1

That could also be extended to grouping presubmits and postsubmits as well
instead of just periodics; giving you a finer grained picture of a subset
of your tests at one time.

On Tue, Oct 22, 2019, 5:44 PM Erick Fejta notifications@github.com wrote:

I would be interested in allowing people to group together related
periodics. It would be useful to hand sig-foo a URL that says "here are all
your sig-foo jobs".

This will most likely span repos, so I'm not sure that requiring periodics
to pin to a repo is the right solution here.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/test-infra/issues/14629?email_source=notifications&email_token=ABG5ENOLURBACVYPENLIUZDQP6M7FA5CNFSM4I5VZOFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB7U66A#issuecomment-545214328,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABG5ENP2KHE4RLIQBR4QJNLQP6M7FANCNFSM4I5VZOFA
.

Noremac201 on 23 Oct 2019

👍1

Depending on _what_ you are trying to convey with those links, we are making good progress. Today, labels and annotations on a ProwJob are exposed via Prometheus so it's possible with join() to create a query that shows you metrics on a specific subset of jobs. If we expand deck to allow for overview pages on jobs with labels, that could bridge the rest of the gap, maybe?

This is orthogonal from the "periodics-that-are-necessarily-related-to-repos-but-not-since-we're-hacking-extra-refs" issue, though ...

stevekuznetsov on 23 Oct 2019

This is orthogonal from the "periodics-that-are-necessarily-related-to-repos-but-not-since-we're-hacking-extra-refs" issue, though ...

Yeah, I think so, too. Doing something to make Deck show jobs that have no refs and len(extra_refs) > 0 when selecting the repo in extra_refs[0] would be pretty nice

alvaroaleman on 23 Oct 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot on 21 Jan 2020

/remove-lifecycle stale

alvaroaleman on 26 Jan 2020

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot on 25 Apr 2020

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

fejta-bot on 25 May 2020

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

fejta-bot on 24 Jun 2020

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.