Test-infra: Postsubmit jobs run on commits where they have been removed

Created on 18 Sep 2019 · 7Comments · Source: kubernetes/test-infra

What happened:
The job post-test-infra-upload-testgrid-config was triggered on a series of commits where that postsubmit job was removed [1]. This caused the job to fail, because it was running on a version of the codebase that it wasn't intended to. Similarly, the final run of maintenance-ci-testgrid-config-upload [2] ran on a commit where it was removed from the config.

What you expected to happen:
Postsubmit jobs to run only if they still exist in the submitted version of the code.

How to reproduce it (as minimally and precisely as possible):
Delete a postsubmit job

Please provide links to example occurrences, if any:

post-test-infra-upload-testgrid-config Spyglass, Revision

maintenance-ci-testgrid-config-upload Spyglass, Revision

Also see Prow History for post-test-infra-upload-testgrid-config and maintenance-ci-testgrid-config-upload

areprow kinbug lifecyclrotten

Source

chases2

Most helpful comment

https://github.com/kubernetes/test-infra/issues/13370 would be the fix to this

alvaroaleman on 22 Sep 2019

👍3

All 7 comments

/area prow

chases2 on 18 Sep 2019

Not sure this will be possible with our current architecture -- the config-updater is entirely async and there's no connection between loaded config and the repo it was loaded from :(

stevekuznetsov on 20 Sep 2019

👍2

https://github.com/kubernetes/test-infra/issues/13370 would be the fix to this

alvaroaleman on 22 Sep 2019

👍3

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot on 21 Dec 2019

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

fejta-bot on 20 Jan 2020

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

fejta-bot on 19 Feb 2020

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.