Test-infra: verify-owners: misleading error message
Currently the verify-owners plugin states that users must be members of the org:
When in reality it is using the trigger.TrustedUser call:
This uses the trigger configuration to do many checks, only one of which is the organization membership one, and only conditionally:
We should make trigger.TrustedUser return a reason for not being trusted so that we can have correct messages.
/help-wanted
stevekuznetsov
All 13 comments
/cc @cblecker @nikhita
stevekuznetsov
on 5 Sep 2019
Related issues: https://github.com/kubernetes/test-infra/issues/13740, https://github.com/kubernetes/test-infra/issues/13002
nikhita
on 5 Sep 2019
/sig contributor-experience
nikhita
on 5 Sep 2019
@nikhita you are so fast! <3
stevekuznetsov
on 5 Sep 2019
hi, could i work on this?
kikisdeliveryservice
on 7 Sep 2019
@kikisdeliveryservice absolutely!
stevekuznetsov
on 7 Sep 2019
@kikisdeliveryservice Is this something you're still looking to work on? :)
cblecker
on 20 Oct 2019
@cblecker yes apologies, I have a wip that I will clean up and push a PR in the next few days
kikisdeliveryservice
on 26 Oct 2019
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
fejta-bot
on 24 Jan 2020
/remove-lifecycle stale
cblecker
on 18 Feb 2020
@stevekuznetsov Do we need to change the error message here or just add the reason as to why we arent trusted like not an org admin
CC @cblecker @nikhita
sladyn98
on 12 Apr 2020
/assign
michaelmdresser
on 15 May 2020
Fixed in #17658
cblecker
on 25 May 2020
Related issues
xiangpengzhao
路
3Comments
cjwagner
路
3Comments
lavalamp
路
3Comments
stevekuznetsov
路
3Comments
BenTheElder
路
4Comments
Most helpful comment
hi, could i work on this?