Test-infra: agnhost build/release process documentation needed

Created on 19 Aug 2019 · 15Comments · Source: kubernetes/test-infra

What should be cleaned up or changed:

It is unclear how to make/test/deploy changes to the agnhost image, which is used for all e2e/conformance testing.

Can we add a section to the readme telling devs:
1) how to make changes to the image
2) how to bump the version
3) host to test their changes to the image
4) how to request a build/push of the new version
5) host to bump the version used in e2e

/cc @spiffxp @kubernetes/sig-release @kubernetes/sig-testing

Provide any links for context:

https://kubernetes.slack.com/archives/C2C40FMNF/p1566144183303200

https://github.com/kubernetes/kubernetes/pull/81271#issue-306307546:

I am unfamiliar with how to test or publish the agnhost images.

https://github.com/kubernetes/kubernetes/pull/81271#issuecomment-520583605:

So, first of all, since this changes webhook, we'll have to bump the image version. bump the version in test/images/agnhost/VERSION. Next, the agnhost version will also have to be bumped in test/utils/image/manifest.go.

I don't think the image promotion automation finished yet, so someone who can build and push the image to gcr.io will have to build and push it.

kincleanup lifecyclrotten

Source

liggitt

All 15 comments

technical process:
make -C test/images all-push WHAT=agnhost

https://github.com/kubernetes/kubernetes/blob/master/test/images/Makefile

human process:
lol. this is another thing where there is none. A googler with access (= on GKE team) needs to be prodded. that should include you and @jpbetz

This should be moved to https://github.com/kubernetes-sigs/k8s-container-image-promoter via wg-k8s-infra.

BenTheElder on 19 Aug 2019

make -C test/images push WHAT=agnhost

does that do all the cross-build stuff necessary?

liggitt on 19 Aug 2019

yes, it should pick up
https://github.com/kubernetes/kubernetes/blob/master/test/images/agnhost/BASEIMAGE
https://github.com/kubernetes/kubernetes/blob/master/test/images/image-util.sh#L41-L44

On Mon, Aug 19, 2019 at 11:20 AM Jordan Liggitt notifications@github.com
wrote:

make -C test/images push WHAT=agnhost

does that do all the cross-build stuff necessary?

—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/test-infra/issues/13968?email_source=notifications&email_token=AAHADK5P7S7SBEDYZXQ7U6DQFLP5RA5CNFSM4INA5TYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4T3JKY#issuecomment-522695851,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAHADK7735W2Y5QEGOF6FK3QFLP5RANCNFSM4INA5TYA
.

BenTheElder on 19 Aug 2019

👍1

ah, the ARCH ?= amd64 line in the makefile threw me off

liggitt on 19 Aug 2019

that tooling is pretty confusing, as per usual...

IMHO test/images is what needs the README, since currently this is setup to
apply to all test images.

On Mon, Aug 19, 2019 at 11:23 AM Jordan Liggitt notifications@github.com
wrote:

ah, the ARCH ?= amd64
https://github.com/kubernetes/kubernetes/blob/master/test/images/agnhost/Makefile#L16
line in the makefile threw me off

—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/test-infra/issues/13968?email_source=notifications&email_token=AAHADK5EM4X5DNIYIS5YAQ3QFLQJ7A5CNFSM4INA5TYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4T3SUI#issuecomment-522697041,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAHADK7OKZVEQ4ZN7W4PO6DQFLQJ7ANCNFSM4INA5TYA
.

BenTheElder on 19 Aug 2019

👍1

/assign

BenTheElder on 19 Aug 2019

I've written a README which covers the general building process for any image, including windows images, workarounds, etc. See here: https://github.com/kubernetes/kubernetes/pull/76838/files#diff-514135d132383981abd050d3e7dfc5ffR1

Regarding the version bump, I've added a short note here: https://github.com/kubernetes/kubernetes/pull/81008/files#diff-1c8a2ba0c34b8fc28df06b45859ebb6fR19

IMO, we could touch all the points noted in the issue in the test/images/README.md file, and we could start from the README I've written.

claudiubelu on 19 Aug 2019

👍1

/assign @bclau
/unassign

BenTheElder on 19 Aug 2019

We also need to include the step of pushing the image to k8s-authenticated-test which is required by e2e, see https://github.com/kubernetes/test-infra/issues/13967#issuecomment-522773030

jpbetz on 20 Aug 2019

I've written a README which covers the general building process for any image, including windows images, workarounds, etc. See here: https://github.com/kubernetes/kubernetes/pull/76838/files#diff-514135d132383981abd050d3e7dfc5ffR1

Regarding the version bump, I've added a short note here: https://github.com/kubernetes/kubernetes/pull/81008/files#diff-1c8a2ba0c34b8fc28df06b45859ebb6fR19

IMO, we could touch all the points noted in the issue in the test/images/README.md file, and we could start from the README I've written.

@bclau currently I see that https://github.com/kubernetes/kubernetes/pull/76838 is taking a lot of time, can we push README in a separate PR for improving the documentation?

mkumatag on 20 Aug 2019

👍1

I've written a README which covers the general building process for any image, including windows images, workarounds, etc. See here: https://github.com/kubernetes/kubernetes/pull/76838/files#diff-514135d132383981abd050d3e7dfc5ffR1
Regarding the version bump, I've added a short note here: https://github.com/kubernetes/kubernetes/pull/81008/files#diff-1c8a2ba0c34b8fc28df06b45859ebb6fR19
IMO, we could touch all the points noted in the issue in the test/images/README.md file, and we could start from the README I've written.

@bclau currently I see that kubernetes/kubernetes#76838 is taking a lot of time, can we push README in a separate PR for improving the documentation?

Done: https://github.com/kubernetes/kubernetes/pull/81662

claudiubelu on 20 Aug 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot on 18 Nov 2019

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

fejta-bot on 18 Dec 2019

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

fejta-bot on 17 Jan 2020

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.