Test-infra: How do we want to handle Tekton versioning?

Created on 17 Aug 2019 · 19Comments · Source: kubernetes/test-infra

What would you like to be added:

I'd like to figure out a process around keeping versions of Prow + Tekton Pipelines in sync. Some ideas:

Update Prow's version of Tekton Pipelines with each release (happy to help with that!)
Change Prow's usage of Tekton Pipelines so it is less tied to the version (e.g. Prow could use just raw json data so it doesn't need to know about the structure of the PipelineRun?)

Why is this needed:

In the context of https://github.com/tektoncd/pipeline/issues/922 (and thanks to https://github.com/tektoncd/pipeline/issues/1187 !) I was able to setup Prow + Tekton Pipelines, however one big issue I encountered was that the version of Tekton being vendored in for Prow is older (I think it's 0.2.0 but it also works up to 0.3.1 - specifically the trigger field was removed but in the version used by Prow it both has to be present and has to be set to manual (there might be a better way around this tho!).

We'd like to be able to use more recent versions of Tekton (if not HEAD) and trigger via Prow.

areprow areproknative-build kinfeature lifecyclrotten

Source

bobcatfish

All 19 comments

@bobcatfish see https://github.com/kubernetes/test-infra/pull/13719 (should bump to 0.6.0 :pray: )

vdemeester on 19 Aug 2019

@bobcatfish do you have any news about making prow + tekton with a higher version than 0.5.2 ?

eddycharly on 29 Oct 2019

@eddycharly I need to re-do https://github.com/kubernetes/test-infra/pull/14216 :angel:

vdemeester on 29 Oct 2019

@vdemeester 👍
if you don't have time, maybe i can help, would be happy to contribute 😄

eddycharly on 29 Oct 2019

@eddycharly happy to get help on that. There is two things to do (related to #14216)

Removing knative/build support in test-infra (as it's deprecated and it's what )
Updating tektoncd/pipeline :angel:

vdemeester on 29 Oct 2019

could we do that in two separate pull requests or should it be done in the same one ?
i will try to work on this asap and let you know.

eddycharly on 29 Oct 2019

@eddycharly can be in separate pull requests, I even think it is better to have 2 separate PR. Removing the knative build dependency is the first step.

vdemeester on 29 Oct 2019

@vdemeester are there instructions to build the projects in the repository ?
i started changing things, trying to figure out how to build now...

eddycharly on 29 Oct 2019

never used bazel before... trying bazel test //... 🤞

eddycharly on 29 Oct 2019

😄1

bazel build //prow/... found the docs...

is it supposed to build on mac ?

ERROR: /private/var/tmp/_bazel_charlesbreteche/42dc72a11735a84e3aad14550c4ca981/external/org_golang_google_grpc/internal/syscall/BUILD.bazel:3:1: GoCompilePkg external/org_golang_google_grpc/internal/syscall/linux_amd64_
pure_stripped/go_default_library%/google.golang.org/grpc/internal/syscall.a failed (Exit 1) builder failed: error executing command bazel-out/host/bin/external/go_sdk/builder compilepkg -sdk external/go_sdk -installsuffix linux_amd64 -src external/org_golang_google_grpc/internal/syscall/syscall_linux.go -src ... (remaining 19 argument(s) skipped)

Use --sandbox_debug to see verbose messages from the sandbox
compilepkg: missing strict dependencies:
        /private/var/tmp/_bazel_charlesbreteche/42dc72a11735a84e3aad14550c4ca981/sandbox/darwin-sandbox/5921/execroot/io_k8s_test_infra/external/org_golang_google_grpc/internal/syscall/syscall_linux.go: import of "golang
.org/x/sys/unix"

eddycharly on 29 Oct 2019

making progress : bazel build --platforms=@io_bazel_rules_go//go/toolchain:linux_amd64 //prow/... works fine !

eddycharly on 29 Oct 2019

/assign eddycharly
:pray: :heart:

bobcatfish on 30 Oct 2019

@vdemeester First step done in https://github.com/kubernetes/test-infra/pull/15022
Now let's update tekton pipeline ;)

eddycharly on 1 Nov 2019

❤1

Here we go https://github.com/kubernetes/test-infra/pull/15072

eddycharly on 2 Nov 2019

❤1

@eddycharly Thanks :heart_eyes_cat:

vdemeester on 4 Nov 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot on 2 Feb 2020

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

fejta-bot on 3 Mar 2020

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

fejta-bot on 26 Apr 2020

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.