Test-infra: Pony plugin: Cope with multiple requests in one comment

Created on 16 Aug 2019 · 15Comments · Source: kubernetes/test-infra

What would you like to be added:

Currently the pony plugin will only search for the first pony request it got in a comment, i.E. the comment:

/pony template
/pony boo

Will result in a "Couldn't find a pony for that query" and no boo pony which is disappointing. Instead, the pony plugin should look for both a template and a boo pony and post both of them or an error for each.

Why is this needed:

good first issue help wanted kinfeature prioritcritical-urgent

Source

alvaroaleman

Most helpful comment

@alvaroaleman: Couldn't find a pony matching that query.

In response to this:

What would you like to be added:

Currently the pony plugin will only search for the first pony request it got in a comment, i.E. the comment:
/pony template
/pony boo
Will result in a "Couldn't find a pony for that query" and no boo pony which is disappointing. Instead, the pony plugin should look for both a template and a boo pony and post both of them or an error for each.

Why is this needed:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot on 16 Aug 2019

😄6

All 15 comments

@alvaroaleman: Couldn't find a pony matching that query.

In response to this:

What would you like to be added:

Currently the pony plugin will only search for the first pony request it got in a comment, i.E. the comment:
/pony template
/pony boo
Will result in a "Couldn't find a pony for that query" and no boo pony which is disappointing. Instead, the pony plugin should look for both a template and a boo pony and post both of them or an error for each.

Why is this needed:

k8s-ci-robot on 16 Aug 2019

😄6

/help
/good-first-issue

fejta on 16 Aug 2019

@fejta:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/help
/good-first-issue

k8s-ci-robot on 16 Aug 2019

This requires updating https://github.com/kubernetes/test-infra/blob/4c871f02efffa9a6cd424644c0b0d1e8abe29907/prow/plugins/pony/pony.go#L128 and surrounding code to match N ponies instead of just 1. Probably should involve a ceiling on N.

Talk to @Katharine for any help

fejta on 16 Aug 2019

/assign

praveensastry on 22 Aug 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot on 20 Nov 2019

/remove-lifecycle stale

On Wed 20 Nov, 2019, 8:05 AM fejta-bot, notifications@github.com wrote:

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually
close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta
https://github.com/fejta.
/lifecycle stale

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/test-infra/issues/13938?email_source=notifications&email_token=AD24BUG5M5ETYMCO6CAFU2DQUVN35A5CNFSM4IMFQF7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEESQOVY#issuecomment-556074839,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AD24BUG6UXG3TRGLQH3NUDTQUVN35ANCNFSM4IMFQF7A
.