Test-infra: The tide "not mergeable" status should use a colon, not a full stop

Created on 25 Jun 2019 · 12Comments · Source: kubernetes/test-infra

Tide statuses read like "Not mergeable. Some explanation."

Aside from being poor grammar, it's also confusing - it suggests that it's not mergeable (e.g. due to a merge conflict) _and also_ "some explanation".

It should instead read "Not mergeable: some explanation." This makes it clear that the explanation is about why it's not mergeable. It also reads better.

areprow areprotide kinbug lifecyclrotten sitesting

Source

Katharine

Most helpful comment

Alternatively, always use a colon and fall back to "Not mergeable: ????", which is probably what the users are thinking when it doesn't clarify anyway.

Katharine on 26 Jun 2019

😄2 🚀1 ❤1

All 12 comments

Currently that's to support the case where there is no reason, to allow the full reason to be "Not mergeable." Agreed that's suboptimal

stevekuznetsov on 25 Jun 2019

Should have logic to figure out the correct punctuation!

I filed this issue after someone was actually confused by it.

Katharine on 26 Jun 2019

👍1

Alternatively, always use a colon and fall back to "Not mergeable: ????", which is probably what the users are thinking when it doesn't clarify anyway.

Katharine on 26 Jun 2019

😄2 🚀1 ❤1

/cc @cjwagner

stevekuznetsov on 26 Jun 2019

I wonder if status context description text will display emojis. Emojis don't need punctuation.

cjwagner on 26 Jun 2019

❤2

/sig testing

spiffxp on 6 Aug 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot on 4 Nov 2019

I still care! This should not be hard to fix, either.

/remove-lifecycle stale

Katharine on 4 Nov 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot on 2 Feb 2020

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

fejta-bot on 3 Mar 2020

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

fejta-bot on 3 Apr 2020

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.