Test-infra: prow: hook: poor ux with invalid /test and /retest commands

[stevekuznetsov]

As a developer interacting with Prow,
I want to get feedback when I've issued a command that could not be parsed
So that I can fix my command and get the service to do what I intended

Examples of comment commands that should generate an error message in a comment response:

• /test with no target
• /retest with trailing words
• /test with a target that is not recognized

/area prow/hook
/good-first-issue
/help
/cc @spiffxp @cblecker @nikhita

[k8s-ci-robot]

@stevekuznetsov:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

As a developer interacting with Prow,
I want to get feedback when I've issued a command that could not be parsed
So that I can fix my command and get the service to do what I intended

Examples of comment commands that should generate an error message in a comment response:

• /test with no target
• /retest with trailing words
• /test with a target that is not recognized

/area prow/hook
/good-first-issue
/help
/cc @spiffxp @cblecker @nikhita

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cblecker]

Is this something the generic command framework would do? Is it worth waiting, or is this simple to do in trigger as it is?

[stevekuznetsov]

I think it would be better implemented with per-plugin logic anyway, I want to see something like:

@user: to request testing, provide a test name like /test test-name

Or

@user: no test fake-test was found for the oops branch on this repo, please select a test from the following options

• unit
• integration

etc.

The framework would have to expose hooks for intelligent responses, so the amount of work taken should be similar in both cases. Changing trigger to do this today should not be too hard.

[nikhita]

For anyone interested to take this up, the trigger plugin is here: https://github.com/kubernetes/test-infra/tree/master/prow/plugins/trigger

[ChristinaLyu0710]

/assign @christinalyu0710

[spiffxp]

/milestone v1.16

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[stevekuznetsov]

/remove-lifecycle stale

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[cblecker]

/remove-lifecycle rotten

[alvaroaleman]

Fixed in https://github.com/kubernetes/test-infra/pull/16926
/close

[k8s-ci-robot]

@alvaroaleman: Closing this issue.

In response to this:

Fixed in https://github.com/kubernetes/test-infra/pull/16926
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.