Test-infra: Rename fejta-bot

Created on 21 Apr 2019  Â·  29Comments  Â·  Source: kubernetes/test-infra

Background: @fejta-bot automatically marks issues as stale/rotten and closes them if they don't have any activity for certain number of days. It is an unprivileged user and is not a member of any of the Kubernetes GitHub orgs.

While enabling fejta-bot automation across all Kubernetes GitHub orgs, it was suggested to rename it to something "official": https://groups.google.com/d/topic/kubernetes-dev/9ps8uNXJ10k/discussion

This issue is to track discussing renaming fejta-bot - what to rename it as or if we should use another account entirely - and making sure that this is rolled out across orgs.

/sig contributor-experience
/sig testing
/cc @cblecker @fejta @spiffxp

aregithub-management kincleanup prioritimportant-soon sicontributor-experience sitesting

Most helpful comment

serious-fejta-bot with a grumpy cat partially converted into a robot for it's profile pic

All 29 comments

serious-fejta-bot with a grumpy cat partially converted into a robot for it's profile pic

/assign

Assigning it to myself to try to move this along in contribex

Any reason not to use one of the existing robots?

We need prow to react to the comments posted by these jobs, so it can't be @k8s-ci-robot. We could maybe use @k8s-github-robot, but I would prefer using a bot that has no privileges.

You'll want to rename more than the account:

Things @fejta-bot does:

  • /lifecycle stale | /lifecycle rotten | /close
  • /retest
  • /check-cla
  • comment that API review may be needed
  • create github issues

Naming is hard, WDYT of either of these?

  • @k8s-triage-robot
  • @k8s-commenter-robot

/milestone v1.16
/assign

k8s-cuddle-bot
k8s-repo-sanity-bot
k8s-triage-bot

+1 to k8s-triage-[ro]bot!
Can probably dovetail with some of the stuff mentioned here: https://github.com/kubernetes/community/issues/3456

+1 to k8s-triage-bot

fajita-bot

+1 to k8s-triage-robot. Since we have -robot suffixes for our other bot accounts, using -robot feels consistent.

To be clear, this would be creating a new account instead of renaming the original one, right? I'm assuming @fejta would like to keep @fejta-bot around for testing, etc... @fejta can you confirm? :)

/area github-management

To be clear, this would be creating a new account instead of renaming the original one, right? I'm assuming @fejta would like to keep @fejta-bot around for testing, etc... @fejta can you confirm? :)

I spoke offline with fejta last week and am confirming by proxy, as he's out this week

I've squatted on http://github.com/k8s-triage-robot, what needs to happen now is:

  • an avatar
  • making a token
  • getting test-infra oncall to add the new secret to the cluster
  • swapping the jobs to use the new token
  • renaming the jobs / dashboards referenced above

note that fejta-bot is not a member of the org, doesn't have any privileges, doesn't need to have 2fa enabled; if we want that to change, I'd rather consider that out of scope here, and ask that those so motivated create a followup issue to

swapping the jobs to use the new token
renaming the jobs / dashboards referenced above

Created https://github.com/kubernetes/test-infra/pull/13683 to get the ball rolling

an avatar

Do we know who created the avatar for @k8s-github-robot? It's pretty dope!

Do we know who created the avatar for @k8s-github-robot? It's pretty dope!

👋 😄

/priority important-soon

Some avatar ideas from @alexcontini

image

@nikhita: Reopened this issue.

In response to this:

/reopen

reverted in https://github.com/kubernetes/test-infra/pull/14548

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

/remove-lifecycle rotten

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

/remove-lifecycle stale

On Tue, Jul 14, 2020 at 8:05 PM fejta-bot notifications@github.com wrote:

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually
close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta
https://github.com/fejta.
/lifecycle stale

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/test-infra/issues/12296#issuecomment-658217260,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AD24BUEGR6CXJ6ZJWTD3ICDR3RUM3ANCNFSM4HHLK64A
.

@spiffxp @nikhita Is there anything I can do to help push this forward?

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

I don't have a strong opinion on this but the errors in https://github.com/kubernetes/test-infra/pull/14548#issuecomment-755628839 seem dubious. This issue should be pretty straightforward if someone wants to do it, otherwise we should probably close it out.

/remove-lifecycle rotten
/milestone v1.21
Agree this should be straightforward

Was this page helpful?
0 / 5 - 0 ratings