Test-infra: The Ability To Set Default Clone URI

Created on 3 Mar 2019 · 11Comments · Source: kubernetes/test-infra

What would you like to be added:
I would like the ability to be able to set the default clone_uri to be used by clonerefs... so I don't have to specify a clone_uri for every job, if my github endpoint is different.

Why is this needed:
Without this feature, GitHub Enterprise users would have to specify clone_uri for each prowJob.

/area prow/clonerefs

areproclonerefs kinfeature lifecyclrotten

Source

midnightconman

👀1

Most helpful comment

Sweet, I'll take this.

/assign

midnightconman on 5 Mar 2019

❤2

All 11 comments

I wonder where we could put that default configuration.

/cc @cjwagner @fejta

stevekuznetsov on 4 Mar 2019

I was thinking at the root of presets in config.yaml, maybe something like:

presets:
default_clone_uri: https://github.mycorp.com
- labels:
  preset-service-account: "true"
  ...

midnightconman on 4 Mar 2019

I think this applies to path_alias and skip_submodules as well. It might also be nice to include extra_refs: https://github.com/kubernetes/test-infra/blob/e808085f74d1f6f87820f56647f95f03d1bbfddf/prow/config/jobs.go#L384-L399

I think we could add the defaults to plank config like we did with default_decoration_config.

cjwagner on 4 Mar 2019

👍2

Sweet, I'll take this.

/assign

midnightconman on 5 Mar 2019

❤2

@midnightconman Any progress on this?

We're kind of in the same boat, where we'd like to always have a clone_uri of [email protected]: rather than https://github.com/, to make private repos work without having to define clone_uri for all jobs.

Alternatively if we could define clone_uri with template variables like clone_uri: [email protected]:{{ .Refs.Org }}/{{ .Refs.Repo }}.git

Multiply on 15 May 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot on 13 Aug 2019

/remove-lifecycle stale

Multiply on 14 Aug 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot on 12 Nov 2019

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

fejta-bot on 12 Dec 2019

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

fejta-bot on 11 Jan 2020

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.