Test-infra: prow: getting_started_deploy.md: changing config.yaml doesn't work

[listx]

What happened:

Tried to edit config.yaml as described here: https://github.com/kubernetes/test-infra/blob/master/prow/getting_started_deploy.md#add-more-jobs-by-modifying-configyaml

but then the config couldn't pass muster for checkconfig.

What you expected to happen:

Running

bazel run //prow/cmd/checkconfig -- --config-path=path-to/config.yaml

should be OK, but I get:

FATA[0000] Error loading Prow config.                    component=checkconfig error="no default decoration config provided for plank"

How to reproduce it (as minimally and precisely as possible):
Just follow the instructions to https://github.com/kubernetes/test-infra/blob/master/prow/getting_started_deploy.md#add-more-jobs-by-modifying-configyaml

Please provide links to example occurrences, if any:

Anything else we need to know?:

Removing "decorate: true" from presubmits and postsubmits seems to make the error go away.

[stevekuznetsov]

@BenTheElder do we just want to suggest adding the stanza that is in your config? We'd want the bump scripts to update the image tags though

[BenTheElder]

Yeah I'm wondering if we should just put this in starter.yaml and make it get bumped along with prow.

[ixdy]

@stevekuznetsov what stanza were you talking about?

[stevekuznetsov]

This one:

https://github.com/kubernetes/test-infra/blob/563bcb31644e30832fe6a5019d6107d3ec49f07f/prow/config.yaml#L6-L19

[ixdy]

The issue I was actually running into is that we have the job configurations in a separate YAML (similar to the way it's done in k/t-i) and forgot to provide both --config-path and --job-config-path to mkpj.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[stevekuznetsov]

/remove-lifecycle rotten
With @Katharine auto-bumper it should be trivial to update the image versions in this file to match those that are currently deployed.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.