Test-infra: prow/cat: 'no' keyword should always show grumpy cat

Created on 19 Jan 2019  路  22Comments  路  Source: kubernetes/test-infra

What would you like to be added:
Using the /meow no command should always display a picture of grumpy cat. Is there really a better way to say no to someone?

Why is this needed:
This is a silly question.

areprow good first issue help wanted kinfeature prioritcritical-urgent sicontributor-experience

Most helpful comment

Nah, we'd just need to explicitly catch "no" and point it at a hardcoded URL.

All 22 comments

/cc @BenTheElder @fejta

cc @Katharine

/pony no

@fejta: pony image

In response to this:

/pony no

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

/remove-lifecycle stale

lol...practically speaking, this would require a change to the cat api, right?

Nah, we'd just need to explicitly catch "no" and point it at a hardcoded URL.

/good-first-issue

@nikhita:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

I am working on this. I will push a PR soon.

@nzoueidi are you still working on this? If not, I'd like to.

yes @mirandachrist but if you would like you can take it, I will share with you my findings :)

thanks @nzoueidi it'll be great for me to do as a first issue! If you have any tips or photo suggestions please let me know :)

/meow no

@mirandachrist: cat image

In response to this:

/meow no

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/close

@mirandachrist: You can't close an active issue/PR unless you authored it or you are a collaborator.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Closed in #12841. Thanks @mirandachrist!

/close

@cblecker: Closing this issue.

In response to this:

Closed in #12841. Thanks @mirandachrist!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/meow no

@spiffxp: cat image

In response to this:

/meow no

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

stevekuznetsov picture stevekuznetsov  路  4Comments

xiangpengzhao picture xiangpengzhao  路  3Comments

BenTheElder picture BenTheElder  路  4Comments

BenTheElder picture BenTheElder  路  4Comments

lavalamp picture lavalamp  路  3Comments