Test-infra: Some plugin configuration is not displayed in plugin help information.

Created on 11 Jan 2019  路  7Comments  路  Source: kubernetes/test-infra

What happened:
Multiple plugins are not exposing information about their current configuration via the PluginHelp structs as they should be.
What you expected to happen:
These plugins should expose config using the PluginHelp.Config field: https://github.com/kubernetes/test-infra/blob/fa2d9efca4e638ddc1e0499464b7ed116034806d/prow/pluginhelp/pluginhelp.go#L44-L47

  • lgtm
  • updateconfig
  • size (Config is included in the wrong field.)

Anything else we need to know?:
This info will be used in the details sections here: https://prow.k8s.io/plugins

/area prow/plugins
/help

kinbug

All 7 comments

We don't have a way to set updateconfig configs per repo currently, do we?

We don't have a way to set updateconfig configs per repo currently, do we?

No, currently the plugin assumes that it is only enabled on a single repository.

/assign
/remove-help

These are the identified plugins:

  • [x] cat (critical one!) (#11187)
  • [x] golint (#11188)
  • [x] label (#11190)
  • [x] lgtm (#11193)
  • [x] size (#11170)
  • [x] verify-owners (#11191)

Alright, so now I have a couple of plugins to fix regarding the validation of enabledRepos:

  • [x] approve (#11342)
  • [x] blockade (#11343)
  • [x] slackevents (#11344)
  • [x] trigger (#11345)
  • [x] welcome (#11347)

Thanks @fejta !
/close

@matthyx: Closing this issue.

In response to this:

Thanks @fejta !
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

stevekuznetsov picture stevekuznetsov  路  3Comments

zacharysarah picture zacharysarah  路  3Comments

spiffxp picture spiffxp  路  3Comments

sjenning picture sjenning  路  4Comments

BenTheElder picture BenTheElder  路  3Comments