Test-infra: label_sync: split into repo specific config files

[nikhita]

I wanted to add new labels to some of the published staging repos and while discussing about this in #sig-contribex in slack, @spiffxp pointed out that while adding the new labels to labels.yaml is the right way to proceed, adding lots of new ones is soon going to make that file 5k lines long. :)

From a scalability standpoint, it is important to refactor that file. One way of doing so is to split it up into smaller repo-specific configs -- similar to how we do for jobs today.

/sig contributor-experience
/area label_sync
/kind feature
/cc @spiffxp @cblecker @fejta

[fejta]

Please do not follow the prow pattern, where we collate all the files together at runtime.

Instead please use a bazel genrule to do this, like we do for peribolos in the org repo

https://github.com/kubernetes/org/blob/e55d4e342e01648b04a0f23044102d0ad8aed4c4/admin/BUILD.bazel#L7

https://github.com/kubernetes/org/blob/e55d4e342e01648b04a0f23044102d0ad8aed4c4/config/BUILD.bazel#L3-L18

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[midnightconman]

@fejta - Can you comment more on the benefit of this approach? Is this still limited by the 1MB configMap limit?

[stevekuznetsov]

The Prow approach is nice, though, because it lets other deployments of Prow have their config repos set up without bazel and still benefit from the split

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[cblecker]

/remove-lifecycle rotten

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[spiffxp]

/remove-lifecycle stale
/help
I'm personally still not sold on the learning curve of bazel, but I agree with @fejta that the pattern used in kubernetes/org is pretty straightforward and has worked well there. So I think this is clear enough for a new contributor to follow, but not marking as good first issue because of bazel.

Another option would be to bake that merging logic into the tool itself, and update it to point at a path with a well-defined structure instead of a single file.

[k8s-ci-robot]

@spiffxp:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/remove-lifecycle stale
/help
I'm personally still not sold on the learning curve of bazel, but I agree with @fejta that the pattern used in kubernetes/org is pretty straightforward and has worked well there. So I think this is clear enough for a new contributor to follow, but not marking as good first issue because of bazel.

Another option would be to bake that merging logic into the tool itself, and update it to point at a path with a well-defined structure instead of a single file.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[cblecker]

/remove-lifecycle stale

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[cblecker]

/remove-lifecycle rotten

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.