Test-infra: Command isn't recognized in comment left via email reply

[xiangpengzhao]

See: https://github.com/kubernetes/community/issues/923#issuecomment-430126237

bot didn't recognize command /remove-lifecycle stale in such comment.

[nikhita]

I wonder if that's a one-off thing because I use commands via email replies when I'm aware of the issue/PR _lots_ of times and it works. :eyes:

Examples:

https://github.com/kubernetes/kubernetes/issues/65973#issuecomment-427685620
https://github.com/kubernetes/kubernetes/issues/62326#issuecomment-427762483
https://github.com/kubernetes/code-generator/issues/24#issuecomment-425714928
https://github.com/kubernetes/kubectl/issues/490#issuecomment-415091866
https://github.com/kubernetes/kube-openapi/issues/75#issuecomment-415091789

[xiangpengzhao]

@nikhita it seems so.
/cc @BenTheElder PTAL :)

[BenTheElder]

/woof

On Fri, Oct 19, 2018, 20:03 Peter (XiangPeng) Zhao [e-mail]
wrote:

@nikhita https://github.com/nikhita it seems so.
/cc @BenTheElder https://github.com/BenTheElder PTAL :)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/test-infra/issues/9834#issuecomment-431543445,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA4Bq6TJ3zGSIGmEo8uUGlANOMh_-t1tks5umpJwgaJpZM4Xi_XA
.

[k8s-ci-robot]

@BenTheElder:

In response to this:

/woof

On Fri, Oct 19, 2018, 20:03 Peter (XiangPeng) Zhao [e-mail]
wrote:

@nikhita https://github.com/nikhita it seems so.
/cc @BenTheElder https://github.com/BenTheElder PTAL :)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/test-infra/issues/9834#issuecomment-431543445,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA4Bq6TJ3zGSIGmEo8uUGlANOMh_-t1tks5umpJwgaJpZM4Xi_XA
.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[BenTheElder]

I also use commands via email pretty often, I'd guess we just missed a webhook for yours.

[nikhita]

I also use commands via email pretty often, I'd guess we just missed a webhook for yours.

Looks like this was the case. I'll close this issue for now. Let's reopen again if we see this happening frequently.

/close

[k8s-ci-robot]

@nikhita: Closing this issue.

In response to this:

I also use commands via email pretty often, I'd guess we just missed a webhook for yours.

Looks like this was the case. I'll close this issue for now. Let's reopen again if we see this happening frequently.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[TBBle]

Just saw (probably) this happen on https://github.com/kubernetes/kubernetes/issues/80996, which was closed because https://github.com/kubernetes/kubernetes/issues/80996#issuecomment-633327886 was apparently ignored or missed, and that went unnoticed by the issue author.

[nikhita]

Just saw (probably) this happen on kubernetes/kubernetes#80996, which was closed because kubernetes/kubernetes#80996 (comment) was apparently ignored or missed, and that went unnoticed by the issue author.

I have admin access on the repo, so I looked at the raw text for the comment https://github.com/kubernetes/kubernetes/issues/80996#issuecomment-633327886. The comment has an additional space before the /remove-lifcycle rotten text which is why the bot didn't catch it.

In either case, I have reopened the issue for you. :+1:

[TBBle]

Should the bot have accepted that command? I realise that might open up risks of catching commands that were not intended to be caught, but given that the UI renders it 'stripped', it's not wonderful UX that the bot works off whitespace-different data than it shows the users.

[BenTheElder]

That's been rejected in the past and I'd probably expect the maintainers to reject it again, but if you're interested in discussing it again probably a new issue will be more visible.

[TBBle]

As long as it's been discussed, at least I know what to watch out for. I don't use GitHub via email, so it's academic to me personally. Two reported occurrences in two years (_assuming_ the first report here was the same problem) isn't really "happening frequently".