Test-infra: prow: add command to add release notes

Created on 20 Aug 2018 · 14Comments · Source: kubernetes/test-infra

Currently, only a few members have write access to k/k (and rightly so). See https://github.com/kubernetes/community/issues/2465 for more details on this.

The only way to add release notes in k/k is to edit the PR body. If I create a cherry-pick today and the parent PR does not contain a release note, I will need to ping someone with write access or the author of the parent PR to add the release note to the PR body (release notes are generated using the release note on the parent PR body, not the cherry-pick PR body).

The number of people with write access is considerably low now, which means pinging people isn't feasible anymore. See https://github.com/kubernetes/kubernetes/pull/67393#issuecomment-413777550 for an example.

I had discussed about this on slack and @cblecker had mentioned:

in general, we need to figure out a way to handle release notes that doesn't manually require editing PR bodies. I'm not sure what the best way to do that is.. but we do need to have a consistent, single source of truth way to know what release note we will apply. This is actually one of the reasons we haven't completely removed manual write access to k/k

I agree and honestly, I don't know the answer to the above problem. Happy to bikeshed over this though. :)

/cc @cblecker @cjwagner @BenTheElder @tpepper
/sig contributor-experience
/sig release
/area prow

areprow kinfeature lifecyclrotten sicontributor-experience sirelease

Source

nikhita

Most helpful comment

ref: https://github.com/kubernetes/kubernetes/issues/57667 for some discussion/context around current k/k use cases for release notes

spiffxp on 20 Aug 2018

👍3

All 14 comments

/kind feature

nikhita on 20 Aug 2018

So we implement a /release-note "my pr does this"?

dims on 20 Aug 2018

So we implement a /release-note "my pr does this"?

Something like that, but we also need to make sure that multi-line release notes with code blocks, etc are possible. IIRC there was something like this before...

nikhita on 20 Aug 2018

IIRC there was something like this before...

It was removed in https://github.com/kubernetes/test-infra/pull/4718.

nikhita on 20 Aug 2018

Especially with the changes to write permissions since a year ago, this feels like a useful feature to me.

tpepper on 20 Aug 2018

ref: https://github.com/kubernetes/kubernetes/issues/57667 for some discussion/context around current k/k use cases for release notes

spiffxp on 20 Aug 2018

👍3

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot on 18 Nov 2018

/remove-lifecycle stale

nikhita on 20 Nov 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot on 18 Feb 2019

/remove-lifecycle stale

cblecker on 21 Feb 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot on 22 May 2019

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

fejta-bot on 21 Jun 2019

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

fejta-bot on 21 Jul 2019

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.