Test-infra: Fix mungegithub lint errors

[fejta]

Run https://github.com/golang/lint on ./mungegithub/...

/good-first-issue

[k8s-ci-robot]

@fejta:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Run https://github.com/golang/lint on ./mungegithub/...

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[stevekuznetsov]

NACK, less churn is better there?

[fejta]

• This isn't the highest priority
• Getting to where we can delete mungegithub is the best way to resolve these lint errors.

That being said, I think it is worthwhile to fix these errors and make our non-vendored code lint clean.

Fixing this up usually pretty straight forward. If someone volunteers the PR I think we should accept it, although I'd prefer they start with the other areas of the repo.

[palash25]

I would like to take this up @fejta . Should I break up the commits file-wise or sub-directory-wise i.e. One commit for lint errors fixed in one file or one sub-directory?

[palash25]

Also I'm not really sure about the commit guidelines so should I provide a description for each commit about what were the lint errors that were fixed in that commit?

[shubheksha]

Since mungegithub is being removed, is this still relevant?
cc: @cjwagner @BenTheElder

[cjwagner]

No, we can close this now.

[BenTheElder]

This is "fixed". No code is best code /s 🙃

[cjwagner]

https://github.com/kelseyhightower/nocode