Test-infra: prow: sidecar: upload more metadata about the job in finished.json

Created on 21 Mar 2018 · 11Comments · Source: kubernetes/test-infra

While we figure out a long-term plan for job metadata in GCS, we need to shim the sidecar to upload more data into finished.json for backwards compatibility.

/kind bug
/area prow
/assign @rmmh

@rmmh as you're much more familiar with the fields and what they represent, can you either make the changes required or provide a JSON schema/struct definition for the data you'd like to see in finished.json so I can plumb it through?

areprow kinbug lifecyclrotten

Source

stevekuznetsov

Most helpful comment

@krzyzacy was I think?

BenTheElder on 3 Jan 2019

👍2

All 11 comments

@rmmh

stevekuznetsov on 9 Apr 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot on 8 Jul 2018

/remove-lifecycle stale

On Sun, Jul 8, 2018 at 8:13 AM fejta-bot notifications@github.com wrote:

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually
close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta
https://github.com/fejta.
/lifecycle stale

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/test-infra/issues/7364#issuecomment-403294512,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA4Bq9h2zOtuVqBVBY_gM8iW0wKIPO07ks5uEiGigaJpZM4S1Wjd
.

BenTheElder on 9 Jul 2018

ref: https://github.com/kubernetes/test-infra/issues/9510

spiffxp on 6 Oct 2018

/milestone v1.14
/unassign @rmmh

FYI @cjwagner @stevekuznetsov @BenTheElder

I thought someone was working on this but I'm not sure who?

spiffxp on 3 Jan 2019

@krzyzacy was I think?

BenTheElder on 3 Jan 2019

👍2

We have incorporated metadata.json, and all other information are in clone-records.json

I think we can make gubernator & spyglass understand clone-records.json instead?

krzyzacy on 4 Jan 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot on 5 Apr 2019

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

fejta-bot on 5 May 2019

/close
Based on https://github.com/kubernetes/test-infra/issues/3412#issuecomment-465879038 I feel like we've agreed we're uploading enough. Let's open specific issues if there are specific things missing

spiffxp on 10 May 2019

@spiffxp: Closing this issue.

In response to this:

/close
Based on https://github.com/kubernetes/test-infra/issues/3412#issuecomment-465879038 I feel like we've agreed we're uploading enough. Let's open specific issues if there are specific things missing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.