Test-infra: Members should be able to add cherrypick-candidate label to PRs

Created on 19 Mar 2018 · 9Comments · Source: kubernetes/test-infra

My understanding is that there is no command which allows any org member to add this label to their PR (at least according to the list), despite the guide suggesting that the second step of cherry picking is putting that label on the PR.

Could be solved by the /cherrypick command supporting adding the cherrypick-candidate label to PRs.
Like, /cherrypick candidate

areprow kinfeature

Source

jennybuckley

👍2

Most helpful comment

We have been using the cherrypick bot for some months now in openshift as an external prow plugin and it has been working great.

kargakis on 19 Mar 2018

👍2

All 9 comments

/area prow
/kind feature

jennybuckley on 19 Mar 2018

cc @kargakis who has an experimental external plugin for this IIRC
right now cherry picking functionality is not yet moved over to Prow, we should do this. 👍

BenTheElder on 19 Mar 2018

👍1

We have been using the cherrypick bot for some months now in openshift as an external prow plugin and it has been working great.

kargakis on 19 Mar 2018

👍2

https://github.com/kubernetes/test-infra/tree/master/experiment/cherrypicker

Should be moved under https://github.com/kubernetes/test-infra/tree/master/prow/external-plugins/

kargakis on 19 Mar 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot on 18 Jun 2018

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

fejta-bot on 18 Jul 2018

/remove-lifecycle rotten

cblecker on 10 Aug 2018

/close
We have since removed the cherrypick-candidate label. But it would be nice if we could land /cherrypick

spiffxp on 23 Oct 2018

@spiffxp: Closing this issue.

In response to this:

/close
We have since removed the cherrypick-candidate label. But it would be nice if we could land /cherrypick

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.