Test-infra: Improve /test all logic.

[cjwagner]

/test all needs a rework. AlwaysRun jobs shouldn't need to make sure their Trigger regexp matches /test all, it is repetitive and prevents us from distinguishing /test all from /test foo easily. Instead /test all should be recognized as a command and trigger tests in the same way that an /ok-to-test command would. We can then simplify the configured job regexps to only match triggers specific to the job instead of matching both job specific and general triggers. The common case of a /test foo trigger for a job named foo can be defaulted to remove this field from most of the entries in the config.
/assign
/area prow

[BenTheElder]

+1 I had a thread with Joe about this at some point. I think he had some
arguments against it but I don't remember them FWIW 🤷‍♂️

On Thu, Jan 18, 2018, 17:45 Cole Wagner [e-mail] wrote:

/test all needs a rework. AlwaysRun jobs shouldn't need to make sure
their Trigger regexp matches /test all, it is repetitive and prevents us
from distinguishing /test all from /test foo easily. Instead /test all
should be recognized as a command and trigger tests in the same way that an
/ok-to-test command would. We can then simplify the configured job
regexps to only match triggers specific to the job instead of matching both
job specific and general triggers. The common case of a /test foo trigger
for a job named foo can be defaulted to remove this field from most of
the entries in the config.
/assign
/area prow

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/test-infra/issues/6346, or mute the thread
https://github.com/notifications/unsubscribe-auth/AA4Bq1_b7Viot4v7JaxG08CR6Tq1PDL0ks5tL_O_gaJpZM4Rj3nU
.

[BenTheElder]

Ping @spxtr 😁

[spxtr]

I don't remember my argument. Are you thinking of my dislike of /test all vs /test-all (how do we know there's no job named "all"?!)?

[cjwagner]

I would prefer /test-all too, but I think we will still need to support /test all too given that users are already used to that. We could add a presubmit test that ensures there are no presubmit jobs named all.

[cjwagner]

Unintentional close. I was trying to use a word besides fix or close but apparently resolve is also a keyword.
/shrug

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

[BenTheElder]

@cjwagner assuming we still want this
/remove-lifecycle rotten

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[BenTheElder]

/remove-lifecycle stale

On Sun, Aug 19, 2018, 11:45 fejta-bot [e-mail] wrote:

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually
close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta
https://github.com/fejta.
/lifecycle stale

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/test-infra/issues/6346#issuecomment-414147086,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA4Bq3jExReK6ua5YRmma7P5Nj3yX1EJks5uSbJQgaJpZM4Rj3nU
.

[cjwagner]

This is already done.
/close