Test-infra: kuberneretes_verify scenario is not maintainable

Created on 29 Nov 2017 · 19Comments · Source: kubernetes/test-infra

We apparently version golint via pinning each branch to an image that we stop updating.
most of the actual scenario logic is in hack/jenkins bash scripts in k/k which are brittle and heavily dependent on the environment.
we use DooD with an image per branch run from the scenario to provide the expected environment (see also the first point)

/kind bug
/area scenarios
/area images
/assign
/assign @krzyzacy

areimages arescenarios kinbug lifecyclrotten

Source

BenTheElder

Most helpful comment

experimenting with https://github.com/kubernetes/test-infra/pull/10451

krzyzacy on 17 Dec 2018

🎉2

All 19 comments

This affects test--go, verify, and unit jobs.

BenTheElder on 29 Nov 2017

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot on 27 Feb 2018

/remove-lifecycle stale

krzyzacy on 27 Feb 2018

Discussed offline with @ixdy, we've since had some other repos try vendoring golint which works pretty well and has some nice properties:

anyone can simply update it with a PR to the target repo
easy to run locally with the same version
can fix any breaking changes in the PR that updates it

@ixdy suggested we could leverage some bazel features to pin it in the workspace and run from there.

BenTheElder on 4 May 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot on 2 Aug 2018

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

fejta-bot on 1 Sep 2018

/remove-lifecycle rotten

BenTheElder on 1 Sep 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot on 30 Nov 2018

/remove-lifecycle stale

On Thu, Nov 29, 2018 at 4:28 PM fejta-bot notifications@github.com wrote:

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually
close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta
https://github.com/fejta.
/lifecycle stale

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/test-infra/issues/5708#issuecomment-443045368,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA4Bq2ye8i6q17u9LyYpAEKuHjO5itzJks5u0HupgaJpZM4QuY_H
.

BenTheElder on 30 Nov 2018

(of course it's been a year... will try to take an actual stab 😂)

krzyzacy on 15 Dec 2018

experimenting with https://github.com/kubernetes/test-infra/pull/10451

krzyzacy on 17 Dec 2018

🎉2

I don't have bandwidth to cherrypick everything properly, but at least master works without this scenario now. (We can no-op and drop this after three releases 😂 )

krzyzacy on 21 Feb 2019

👍1

I don't remember which changes are needed, but I think I cherry-picked at least some of them.

ixdy on 21 Feb 2019

https://github.com/kubernetes/kubernetes/pull/72668
https://github.com/kubernetes/kubernetes/pull/72669
https://github.com/kubernetes/kubernetes/pull/72670

ixdy on 21 Feb 2019

@amwat finished moving us off of this going forward I think

BenTheElder on 16 Mar 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot on 14 Jun 2019

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

fejta-bot on 14 Jul 2019

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

fejta-bot on 13 Aug 2019

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.