Test-infra: some of the image maintainers are stale

Created on 9 Nov 2017  Â·  22Comments  Â·  Source: kubernetes/test-infra

https://github.com/kubernetes/test-infra/blob/a436c8a85e660c95b384904ceac5ce8d1fdc9395/images/bazelbuild/Dockerfile#L17

FYI @spxtr

Probably should be ixdy or myself now (or a different email addr)

/cc @ixdy
/area images

areimages kinbug prioritimportant-longterm

Most helpful comment

/milestone v1.14

I vote we either kill the use of this, or we use [email protected]

All 22 comments

we should just remove it. MAINTAINER is deprecated.

oh, we're not using MAINTAINER.

I still feel like this field is pretty useless, since it can get out of date easily. maybe it points to sig-testing or this repo or something instead of a specific person?

Yeah, there is also a broader issue that some of our images still use MAINTAINER instead of the label.

I think it's still idiomatic to have _some_ maintainer in the dockerfiles, maybe it could be [email protected] :stuck_out_tongue:

Right now it's been useful as "this is the person who is most familiar with the image, cc them when something is broken" though, which wouldn't be as useful if it just pointed to this repo or sig-testing.

/assign
@krzyzacy and I are planning to clean up our image layering in Q1, we should fix the maintainer labels then.

xref: #5434

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

/remove-lifecycle stale

which ones are left?

I think just maintainers for images we should remove eg images/pull-test-infra-gubernator, a bunch of mungegithub images.

/milestone 1.12

/milestone v1.13
We still have a few people listed who are no longer with the project https://gist.github.com/spiffxp/d4fc10420325b23e26c4b829901f5b5b

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

/shrug

On Thu, Dec 20, 2018 at 2:37 PM fejta-bot notifications@github.com wrote:

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually
close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta
https://github.com/fejta.
/lifecycle stale

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/test-infra/issues/5431#issuecomment-449158182,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA4Bq-VVzoP8HwE_MZvKIEaV0skLhdhEks5u7BElgaJpZM4QYk8b
.

/pony shrug

@ixdy: pony image

In response to this:

/pony shrug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/milestone v1.14

I vote we either kill the use of this, or we use [email protected]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

/remove-lifecycle rotten

sure I'll PR

maybe in the future we can bazel-fy everything xD

/unshrug

@spiffxp: ¯\_(ツ)_/¯

In response to this:

/unshrug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

cjwagner picture cjwagner  Â·  3Comments

fen4o picture fen4o  Â·  4Comments

BenTheElder picture BenTheElder  Â·  3Comments

cblecker picture cblecker  Â·  4Comments

xiangpengzhao picture xiangpengzhao  Â·  3Comments