Test-infra: CONTRIBUTING.md link to maintainers cannot be opened by non-members
The contributing docs currently link to kubernetes/test-infra-maintainers which is a dead link.
I'm not actually seeing a suitable replacement yet though.
/cc @ixdy
BenTheElder
All 13 comments
From another issue, it seems that the link is not bad, just not visible to non-members.
Not sure if this should be fixed or is as-intended.
BenTheElder
on 20 Jul 2017
Oh right, I totally forgot that teams aren't visible to non-org-members. We should link to something more useful for new contributors.
spxtr
on 20 Jul 2017
@spxtr maybe we should add OWNERS files to test-infra so the munger can assign reviewers automatically?
ixdy
on 20 Jul 2017
We should add a CODEOWNERS file so that GitHub assigns reviewers automatically, no need for a munger :)
spxtr
on 20 Jul 2017
I think we should strive to have the same developer experience for all of our repos. Having CODEOWNERS in some places and k8s OWNERS in other places is going to be very confusing for contributors.
The fact that test-infra doesn't have a SQ like other repos has already been problematic.
ixdy
on 20 Jul 2017
Agree with @ixdy
I keep hearing mention of eventually wanting to drive teams from files vs just leaning on githubs teams but I'm not sure if that's a roadmapped plan
spiffxp
on 21 Jul 2017
I'm conflicted about this particular case. I do agree that it's nice to have the same developer experience for all the repos, but I don't think we should wall ourselves off from using native GitHub tooling because we made our own a few months before they made theirs.
It's going off on a tangent from this PR though.
I keep hearing mention of eventually wanting to drive teams from files vs just leaning on githubs teams but I'm not sure if that's a roadmapped plan
We'll still be using GitHub teams, we'll just keep the source of truth in files and sync them regularly.
spxtr
on 21 Jul 2017
I wonder why we make such teams private. Any reasons?
xiangpengzhao
on 21 Jul 2017
I wonder why we make such teams private. Any reasons?
GitHub makes them private with no way to make them public, I think.
spxtr
on 21 Jul 2017
Not sure what we want to do about this or close, at least we have CODEOWNERS/OWNERS now
BenTheElder
on 30 Sep 2017
/assign
BenTheElder
on 5 Dec 2017
/cc @amwat
BenTheElder
on 21 Apr 2018
/assign @amwat
BenTheElder
on 21 Apr 2018
Related issues
cjwagner
路
3Comments
stevekuznetsov
路
4Comments
BenTheElder
路
4Comments
fejta
路
4Comments
cjwagner
路
3Comments
Most helpful comment
GitHub makes them private with no way to make them public, I think.