Test-infra: testgrid should show the new build SHA in upgrade test
e.g., https://k8s-testgrid.appspot.com/1.6-1.7-upgrade
The UI shows the SHA of the old image. It's more useful if the UI instead shows the SHA of the image the cluster is upgraded to, because that's what the release team cares about.
cc @krzyzacy @ixdy
caesarxuchao
All 31 comments
FWIW Gubernator used to show both versions in the metadata at the top, but in some of the job config and test-infra refactoring, it seems like this functionality was lost.
ixdy
on 7 Jul 2017
Update this method to include both versions in the metadata.json, which will result in it getting exposed to both gubernator and testgrid
https://github.com/kubernetes/test-infra/blob/master/kubetest/main.go#L345
fejta
on 7 Jul 2017
/area kubetest
per the above comment
spiffxp
on 20 Oct 2017
@fejta which method, writeMetadata()?
spiffxp
on 20 Oct 2017
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Prevent issues from auto-closing with an /lifecycle frozen comment.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale
fejta-bot
on 18 Jan 2018
/remove-lifecycle stale
this remains a pain point for consumers of testgrid during release
spiffxp
on 19 Jan 2018
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
fejta-bot
on 19 Apr 2018
/remove-lifecycle stale
/lifecycle frozen
krzyzacy
on 19 Apr 2018
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
fejta-bot
on 19 Sep 2018
/remove-lifecycle stale
/assign
I wrote a doc about figuring upgrade versions, it would be way nicer to make that doc smaller and say "just look at gubernator"
spiffxp
on 19 Sep 2018
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
fejta-bot
on 18 Dec 2018
/pony sad
someday someone will work on this.
ixdy
on 18 Dec 2018
@ixdy: 
In response to this:
/pony sad
someday someone will work on this.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
k8s-ci-robot
on 18 Dec 2018
/remove-lifecycle stale
/pony this is fine
krzyzacy
on 18 Dec 2018
@krzyzacy: 
In response to this:
/remove-lifecycle stale
/pony this is fine
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
k8s-ci-robot
on 18 Dec 2018
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
fejta-bot
on 19 Mar 2019
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
fejta-bot
on 18 Apr 2019
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close
fejta-bot
on 18 May 2019
@fejta-bot: Closing this issue.
In response to this:
Rotten issues close after 30d of inactivity.
Reopen the issue with/reopen.
Mark the issue as fresh with/remove-lifecycle rotten.Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
k8s-ci-robot
on 18 May 2019
/reopen
/priority important-soon
/area release-eng
@kubernetes/release-engineering -- Anyone interested in working on this?
justaugustus
on 29 Jul 2019
@justaugustus: Reopened this issue.
In response to this:
/reopen
/priority important-soon
/area release-eng@kubernetes/release-engineering -- Anyone interested in working on this?
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
k8s-ci-robot
on 29 Jul 2019
/remove-lifecycle rotten
/lifecycle frozen
justaugustus
on 29 Jul 2019
@justaugustus i can try this one if i get some initial guide, like where to start :)
cpanato
on 29 Jul 2019
Thanks Carlos! I personally just found this issue.
@spiffxp @fejta -- Can you provide some details on current state of affairs and what Carlos would need to work on this?
/assign @cpanato
justaugustus
on 29 Jul 2019
This was primarily in reference to all of the jobs that now live here: https://testgrid.k8s.io/sig-release-orphaned
They are run via kubetest: https://github.com/kubernetes/test-infra/tree/master/kubetest#upgrade-skew-kubemark
Testgrid columns are defined in testgrid config.yaml like so: https://github.com/kubernetes/test-infra/blob/master/testgrid/config.md#column-headers
So the questions I can't answer off the top of my head and leave to you are:
- how can you identify the versions being upgraded (is it version files, is it api calls)
- where can you do this (is it a change in kubetest, is it a change in something kubetest kicks off)
- where can you store this data such that it ends up in the
metadatasection offinished.json(this one could probably use a docs PR when you find the answer)
spiffxp
on 30 Jul 2019
@spiffxp Thanks Aaron, since I'm quite new to the codebase I will ping you at slack to talk more, of course, if you agree on that :)
cpanato
on 4 Aug 2019
until the rest is agreed there's nothing to do in kubetest, this metadata can just as easily come from the (rather broken) upgrade system.
BenTheElder
on 1 May 2020
/remove-lifecycle frozen
/assign @BenTheElder
putting this on your radar
spiffxp
on 11 Sep 2020
/remove-priority important-soon
spiffxp
on 11 Sep 2020
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
fejta-bot
on 10 Dec 2020
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
fejta-bot
on 9 Jan 2021
Related issues
fen4o
路
4Comments
BenTheElder
路
4Comments
stevekuznetsov
路
3Comments
xiangpengzhao
路
3Comments
cjwagner
路
3Comments
Most helpful comment
@krzyzacy:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.