Test-infra: Do not remove the LGTM label for trusted authors

Created on 30 Jan 2017 · 22Comments · Source: kubernetes/test-infra

.2) revert the anti-lgtm bot for a set of "trusted" authors (likely OWNERS)

And, regardless of which of the two we choose, we will implement a "btw, this was merged with changes" note. We'll try to get the diff, but I'm not positive how easy it is to get the diff from github if the commit has changed.

Per https://groups.google.com/d/msg/kubernetes-dev/SxcnadJQcr0/0GDnkC90BwAJ

areprow help wanted

Source

fejta

Most helpful comment

How about if you own all the files you're modifying we don't remove the LGTM label?

fejta on 28 Jan 2018

👍3

All 22 comments

We'll try to get the diff, but I'm not positive how easy it is to get the diff from github if the commit has changed.

This might be tricky. The problem is that when people force-push or do a rebase, the original git commit drops out and gets garbage collected at some unspecified point. There might be some way around this or some guarantee on how long the old commit sticks around, but there might not.

spxtr on 30 Jan 2017

at least in the web ui, force-pushes show up as new events, could we maybe use the API to just grab commits since the last LGTM label? if it's a whole new patchset vs incremental diff, so be it?

spiffxp on 30 Jan 2017

@pkaminski I'm sure you're busy but hoping you can provide some insight :-). How does Reviewable produce a diff across PR revisions (including force-pushes)? Could the same technique be applicable here?

mtaufen on 1 Feb 2017

To summarize a bunch of fiddly code, Reviewable:

Remembers the commit SHAs for every revision captured by the review.
Creates a git ref (like a branch, but in a separate namespace) for every commit that was captured as a revision, ensuring that it doesn't get garbage collected by GitHub.
Uses the commit SHAs to fetch the corresponding git trees, figure out the relevant file SHAs, fetch the raw file contents, and run its own diff between them.

I'm sure you could reproduce this technique -- and I'm happy to provide more details if desired -- but it might be too much work depending on what you're trying to achieve. BTW, I asked GitHub support previously and they declined to provide any guarantees, or even estimates, on how long it takes for a commit to get GC'd.

pkaminski on 2 Feb 2017

👍1

We need to find an owner, update and/or close

fejta on 15 Aug 2017

/area mungegithub
lgtm-after-commit munger

spiffxp on 19 Aug 2017

Soon, something that will be handled by prow: https://github.com/kubernetes/test-infra/pull/3821
/area prow

kargakis on 20 Aug 2017

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

fejta-bot on 3 Jan 2018

/remove-lifecycle stale
Lots of wishes for something like this when I raised the idea of revoking direct write access to k/k https://github.com/kubernetes/kubernetes/issues/57667

spiffxp on 3 Jan 2018

/unassign @brendandburns

spiffxp on 3 Jan 2018

/remove-area mungegithub

fejta on 28 Jan 2018

How about if you own all the files you're modifying we don't remove the LGTM label?

fejta on 28 Jan 2018

👍3

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot on 28 Apr 2018

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

fejta-bot on 28 May 2018

/remove-lifecycle rotten

nikhita on 13 Jun 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot on 11 Sep 2018

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

fejta-bot on 11 Oct 2018

/assign @hklai
/remove-lifecycle rotten

Should we consider this fixed?

fejta on 2 Nov 2018

@fejta: GitHub didn't allow me to assign the following users: hklai.

Note that only kubernetes members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @hklai
/remove-lifecycle rotten

Should we consider this fixed?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.