Terraform-aws-eks: Specify multiple cluster/worker security groups

[jimbeck]

I have issues

I'm submitting a

• [ ] bug report
• [x] feature request
• [ ] support request

What is the current behavior

The EKS plugin currently supports being able to pass in 1 cluster and worker security group by id.

If this is a bug, how to reproduce? Please include a code sample

What's the expected behavior

I think it would make sense to support specifying an array of security group ids.

Environment

• Affected module version:
• OS:
• Terraform version:

Other relevant info

We have a use case where we need to attach multiple security groups. Some of which are predefined.

[tomfotherby]

We currently use multiple security groups for our Workers as well. This feature would be handy for our migration to this brilliant module.

[brandonjbjelland]

If I'm understanding correctly, we now have 2 feature requests here.

1. to have multiple security groups possible for the eks cluster.
2. to allow any of the worker groups to have one or more SG groups.

The latter is tricker since all the worker attributes are now controlled through a map which is comprised of strings. That would mean the security group list would also need to be a string which is split before used. I think that would work.

Do I have the above right? Are either of you planning to submit a PR for these items?

[tomfotherby]

Yes, you have it right.

No PR planned from me - I'd be afraid to introduce more problems than I solve ;). Seems the language changes planned in Terraform 0.12 later this summer might help with this issue as vars will be able to be lists.

[brandonjbjelland]

We all eagerly await the chaos and harmony that 0.12.x promises to bring 😈

[jimbeck]

Agreed...this definitely seems like 2 feature requests.

1. to have multiple security groups possible for the eks cluster.
2. to allow any of the worker groups to have one or more SG groups.

I can create a PR for the first one later today or tomorrow.
For the second one, do we think it makes sense to hold off until 0.12 or do we want to ensure that it's compatible with the current version of terraform as well?

[tomfotherby]

I guess it's not hard for folks that currently use multiple Security Groups to merge them into 1 as a workaround. Having said that, we would love this feature and waiting for TF v0.12 would be a shame.

[brandonjbjelland]

Thanks @jimbeck . Yea I can make a try at the PR for what @tomfotherby is after.

[max-rocket-internet]

Now supported 👌