Terraform-aws-eks: stop making this module hard to integrate with terragrunt

Created on 16 Dec 2019  路  4Comments  路  Source: terraform-aws-modules/terraform-aws-eks

Some of the logic has to be declared outside of the scope of the module,
making integrating with terragrunt a bit harder (you need to go to manual control to bootstrap)

This seems to be the new way to go in the master branch while tags are still seems to be fine.

The refactoring logic seems to be following an antipattern since the latest 7.0.1 -> master release
Am I missing something? :)

Most helpful comment

You should be using your own wrapper code that includes this module in-line, and pointing Terragrunt at _that_ as your include. This pattern works well for me personally.

All 4 comments

I've only used Terragrunt briefly so you will need to be more specific, with examples.

look at the code v0.7.1 vs master, seems like a big shift in the logic behind the module,
regardless specific code snippet, seems like we are breaking out of the scope of the module, having to declare providers externally as well as TF data sources?

You should be using your own wrapper code that includes this module in-line, and pointing Terragrunt at _that_ as your include. This pattern works well for me personally.

I use Terragrunt a lot, and wrote a module which include the terraform-aws-eks module as @shanesveller suggested. Working great so far (almost 2 years now).

Closing this. Feel free to re-open it if the proposed solution doesn't work for you, or if you have another proposal.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

discordianfish picture discordianfish  路  3Comments

gb-ckedzierski picture gb-ckedzierski  路  5Comments

Pratima picture Pratima  路  4Comments

bshelton229 picture bshelton229  路  4Comments

discordianfish picture discordianfish  路  4Comments