Terra-core: Avatar theme variable typo
Bug Report
Description
Noticed this when wokring on the consumer theme. We have a typo in the --terra-avatar-netural-after-box-shadow variable. It should be --terra-avatar-neutral-after-box-shadow.
Environment
- Component Name and Version: terra-avatar v2.0.0+
bjankord
All 3 comments
My thoughts are we just fix the typo as a patch release but curious to hear what the other maintainers think. cc/ @ryanthemanuel @JakeLaCombe @mjhenkes @tbiethman
I looked through all 1241 theming variables we have in core and this is the only one that had a typo. Thinking of a way we can automate spell check on these so we don't run into this issue again.
bjankord
on 15 Jan 2019
👍3
:(
yuderekyu
on 16 Jan 2019
😄1
I'd say do a patch release. Technically it's non passive, but it's a bug. Let's go ahead and fix/release.
ryanthemanuel
on 16 Jan 2019
Was this page helpful?
0 / 5 - 0 ratings
Related issues
StephenEsser
路
4Comments
SpartaSixZero
路
5Comments
noahbenham
路
5Comments
yuderekyu
路
3Comments
FloraChenCerner
路
4Comments
Most helpful comment
My thoughts are we just fix the typo as a patch release but curious to hear what the other maintainers think. cc/ @ryanthemanuel @JakeLaCombe @mjhenkes @tbiethman
I looked through all 1241 theming variables we have in core and this is the only one that had a typo. Thinking of a way we can automate spell check on these so we don't run into this issue again.