Terminus: [bug]After the shell process end, the tab doesn't close automatic.

[hv0905]

Version: 1.0.73
Platform: win32 10.0.18356
Plugins: clickable-links, save-output, scrollbar, shell-selector
When I type exit or press Ctrl + D in the shell, the shell itself closed but left an empty tab and I have to close it manually.
I noticed #84, however, the issue seems still exist in my computer.

[kjdms]

I had the same problem but I have not experienced it since I upgraded to 1.0.75.

[thebwt]

Currently seeing this in 1.0.77

[Eugeny]

@thebtw are you also using cygwin? Please include your Windows build and whether ConPTY is enabled.

[thebwt]

Build 1803 (17134.765) - conPTY not enabled (that I'm aware of, quick google shows that's in insider only?)

using the version installed by terminus-Setup-1.0.77.exe

[Eugeny]

Can you check if there are any errors in the console? https://github.com/Eugeny/terminus/wiki/Debug-logs

GitHub

Eugeny/terminus

A terminal for a more modern age. Contribute to Eugeny/terminus development by creating an account on GitHub.

[thebwt]

Sure enough:
TypeError: Cannot read property 'removeEventListener' of undefined at HTMLElement.detachFromTerminal (C:\Users\thebw\AppData\Roaming\terminus\plugins\node_modules\terminus-scrollbar\dist\index.js:255) at ScrollbarDecorator.detach (C:\Users\thebw\AppData\Roaming\terminus\plugins\node_modules\terminus-scrollbar\dist\index.js:413) at config.enabledServices.forEach.decorator (baseTerminalTab.component.ts:365) at Array.forEach (<anonymous>) at TerminalTabComponent.ngOnDestroy (baseTerminalTab.component.ts:364) at TerminalTabComponent.ngOnDestroy (terminalTab.component.ts:98) at callProviderLifecycles (C:\Users\thebw\AppData\Local\terminus\app-1.0.77\resources\app.asar\node_modules\@angular\core\bundles\core.umd.js:22442) at callElementProvidersLifecycles (C:\Users\thebw\AppData\Local\terminus\app-1.0.77\resources\app.asar\node_modules\@angular\core\bundles\core.umd.js:22410) at callLifecycleHooksChildrenFirst (C:\Users\thebw\AppData\Local\terminus\app-1.0.77\resources\app.asar\node_modules\@angular\core\bundles\core.umd.js:22400) at Object.destroyView (C:\Users\thebw\AppData\Local\terminus\app-1.0.77\resources\app.asar\node_modules\@angular\core\bundles\core.umd.js:23462) process.on @ entry.preload.ts?2934:37 emit @ events.js:182 window.onerror @ C:\Users\thebw\AppData\Local\terminus\app-1.0.77\resources\electron.asar\renderer\init.js:136

[Eugeny]

Disable the scrollbar plugin - you don't need it with the recent versions with xterm anyway

[thebwt]

That did it!