Terasology: module carts: can't break carts with current development branch.

Created on 7 Apr 2017  路  7Comments  路  Source: MovingBlocks/Terasology

I'm working on the rails module and I am not able to break the cart for development. I ran git-bisect and found this revision produced the bug. It could be something else unrelated but this is what I've narrowed it down to. Could require modifying the Core module, but this revision produces a regression in terms of the HealthComponent and Entities. Would have to see how this affects other modules.

0d3ce8e3e7356e1bce80e5f271e321fde5b5f261

What you were trying to do

What actually happened

How to reproduce

  • Install Rails mod: https://github.com/Terasology/Rails
  • checkout revision: 0d3ce8e3e7356e1bce80e5f271e321fde5b5f261
  • can't break cart
  • checkout revision 0d3ce8e3e7356e1bce80e5f271e321fde5b5f261~1
  • can break cart
Bug

Most helpful comment

I'll take a look at this over the weekend.

All 7 comments

@indianajohn

I'll take a look at this over the weekend.

I was testing this with the WildAnimals mod. I can't hit any of the deer.

I'm working on this now, I think I see a way to fix it. Shouldn't take too long.

I think my pull request may of fixed the issue unless you have something else in mind @indianajohn #2891

Nope, I was unaware of that PR. That is basically what I was about to end up with.

Anyway, sorry for any trouble this caused and thanks for the fix.

was pretty happy that I got to use git-bisect

Was this page helpful?
0 / 5 - 0 ratings