Temporary-containers: Exclude colors from random container color

[Gitoffthelawn]

FF v67.0.4 64-bit, TC v0.101

Before updating to TC v0.101, Containers Theme extension always showed a color for each temporary container.

Now, with TC v0.101, the Containers Theme extension usually shows a color, but sometimes uses the color gray.

Perhaps you can fix this?

Thanks!

[stoically]

This would need a feature to exclude colors when random container colors is selected. Firefox 67 added the "toolbar" color, which is black or gray, depending on your theme.

[foxdan]

👍 this is a feature I'd like for a different reason.

To use different random colours from those I use for permanent containers to still easily distinguish amongst them.

Happy to have a look at this if PRs are welcome.

[Gitoffthelawn]

@stoically
Interesting. Thanks. I never encountered gray until today, even though FF 67 has been out for a while. I wonder why.

Is the fence icon a new FF 67 icon as well? It seems now to be in the rotation when Random Container Icons is enabled. Does it have any special meaning, or is it just another random icon in this case?

[stoically]

@foxdan Sure, PRs are more than welcome. I'd imagine to use a multiple selection and either hide it until random container color is selected, or make it a separate option in the advanced tab. Sorry for the code mess, good luck and let me know if I can be of help.

@Gitoffthelawn The fence is just another icon, also added with Firefox 67. Version 0.101 made the new color and icon available in TC.

[stoically]

@foxdan Just FYI, the latest added feature (#104) required a multiple selection too and I found it a bit tricky to fill it with values programmatically and get the selected values afterwards. That's what worked for me: options.html, options.js, shared.js

[stoically]

v1.0beta15 allows excluding of colors and icons when random is selected.

@foxdan Sorry about inviting you to PR and then doing massive refactorings.

[Gitoffthelawn]

@stoically Thanks for your hard work! Could it be possible to add colors (and maybe even icons)?

[stoically]

That's not supported by the Firefox API, so I can't help with that. Related: https://github.com/mozilla/multi-account-containers/issues/391