Teams-for-linux: "Open" from the tray menu does not focus the window

[Niezoor]

If the application window is already open, clicking "Open" in the tray menu does not focus on the application window.

Tested on Ubuntu 16.04

[IsmaelMartinez]

Hi,

Does this happen when the app is minimised, close, in the background (under another app) or always?

Thanks

[IsmaelMartinez]

Also, can you provide more information about what have you install the application with? deb, tar.gz, AppImage, snap, running from source...

Can you run it from the command line teams-for-linux and see if you get any log messages? You might need to look in /var/log/syslog (or whatever your linux put the syslogs/messages)

[Niezoor]

Hi,

This problem always occurs when application in the background (under another app).
When the application is minimized, it works correctly only at the first time.
It always works correctly when application widow is closed/hided.

I installed application using snap.

My log shows only:
realpath: '': No such file or directory
realpath: '': No such file or directory
realpath: '': No such file or directory
realpath: '': No such file or directory
realpath: '': No such file or directory
realpath: '': No such file or directory
realpath: '': No such file or directory
realpath: '': No such file or directory
Gtk-Message: Failed to load module "canberra-gtk-module"
Gtk-Message: Failed to load module "canberra-gtk-module"

Thanks

[IsmaelMartinez]

Can you try with the deb package or running from sources? Just to rule out is not a snap package issue (permissions etc)

[Niezoor]

The same happens after install from deb package and running from sources.

[IsmaelMartinez]

I keep it open and see if someone else is having this issue. I got Ubuntu 18.04 and works in the cases.

[alexeiskachykhin]

@IsmaelMartinez I'm having the same issue on both Ubuntu 18.04 and 16.04. Steps to reproduce:

1. Launch the application
2. Minimize the application by clicking on its icon in a taskbar
3. Click Open in a tray

No errors are logged to a terminal or chrome dev tools, it just doesn't work.

It looks like there might be a straightforward fix for it in menus/index.js:

    open() {
        if (!this.window.isVisible()) {
            this.window.show();
        }

        this.window.focus();
    }

It fixes a problem for me and a window gets predictably restored.

[IsmaelMartinez]

Hi @alexeiskachykhin ,

Thanks for the PR and for investigating the issue. It's a strange one as it works fine in my environment but I am using Kubuntu.

I will test that in my environment as soon as I can (but I am with limited internet access at the moment) and accept the PR.

Maybe @julian-alarcon or @benyanke can do that before me.

Thanks again!!

[IsmaelMartinez]

closing as it is now in master, ready for release. Might be able to release something next week

[IsmaelMartinez]

Sorry but looks like the packaged "release" will need to wait until the end of the month (life commitments).

If you are using snap, you an use the edge branch (that is the current source, or at least got your changes).

Apologies!

[IsmaelMartinez]

Managed to release yesterday . Thanks again for your contribution!!

[alexeiskachykhin]

Hi Ismael,

Thank you for letting me know. Have a great weekend.

Get Outlook for Androidhttps://aka.ms/ghei36

---

From: IsmaelMartinez [e-mail]
Sent: Saturday, April 13, 2019 4:29:10 AM
To: IsmaelMartinez/teams-for-linux
Cc: Alexei Skachykhin; Mention
Subject: Re: [IsmaelMartinez/teams-for-linux] "Open" from the tray menu does not focus the window (#81)

Managed to release yesterday . Thanks again for your contribution!!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FIsmaelMartinez%2Fteams-for-linux%2Fissues%2F81%23issuecomment-482789147&data=02%7C01%7C%7C84407e07d96142a4e0bc08d6bfea1ad0%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636907409519188488&sdata=4b9iSOBcPFcwz5dVKHL7QqzayfLUzqDuz1A7cw6p5x8%3D&reserved=0, or mute the threadhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACqIfqjICgcfEElkas4Jm5v7-kulzIIRks5vgZVWgaJpZM4cHS4Q&data=02%7C01%7C%7C84407e07d96142a4e0bc08d6bfea1ad0%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636907409519198493&sdata=wwFQi1PMoLHf1U1dPIEpgvLYhCVaIJERFY3lQ6gVPHI%3D&reserved=0.