Teammates: Instructor: remind particular student: fix stray place holder in email text

Created on 17 Mar 2018  路  4Comments  路  Source: TEAMMATES/teammates

found in: v6.3.0, v6.4.0 (I didn't check earlier versions)

Steps:

  • Add the instructor as a student
  • Have a session that has questions for students as well as instructors
  • Send a reminder using 'remind particular student' option in instructor home page

Actual: one of the emails sent has a placeholder text instead of actual content

image

p.High

Most helpful comment

Found the reason of this bug.

https://github.com/TEAMMATES/teammates/blob/8a974ee703c46f4b3280552f46b3e767eb561eab/src/main/java/teammates/logic/api/EmailGenerator.java#L96-L102

additionalContactInformation was not passed to generateFeedbackSessionEmailBasesForInstructorReminders in the argument, which is why the placeholder was not getting replaced.

[Screenshot of the email before passing the parameter]
screenshot 451

[Screenshot of the email after passing the parameter]
screenshot 452

Sending a PR within an hour.

All 4 comments

The problem is in the email sent to instructors asking them to submit responses.

Related to #8182?

Looking into it.

Found the reason of this bug.

https://github.com/TEAMMATES/teammates/blob/8a974ee703c46f4b3280552f46b3e767eb561eab/src/main/java/teammates/logic/api/EmailGenerator.java#L96-L102

additionalContactInformation was not passed to generateFeedbackSessionEmailBasesForInstructorReminders in the argument, which is why the placeholder was not getting replaced.

[Screenshot of the email before passing the parameter]
screenshot 451

[Screenshot of the email after passing the parameter]
screenshot 452

Sending a PR within an hour.

Was this page helpful?
0 / 5 - 0 ratings