Teammates: Instructor: edit 'Distribute points' questions: make status message span both label and input

Created on 3 Aug 2017  路  17Comments  路  Source: TEAMMATES/teammates

In the student feedback edit page under the Distribute points (among recipients) question, currently, the status message spans only the _input field_.

Current Behaviour:
Sample Image

Expected:
status message should span both _input label_ and _input field_.

a-UIX help wanted p.Low

Most helpful comment

I think my master branch is not updated 馃槄

All 17 comments

Duplicate of #7876; already fixed in #7879. Can confirm?

I think my master branch is not updated 馃槄

@whipermr5 Just synchronized my master branch with the upstream/master branch but the message remains unaligned.

_[screenshot]_
screenshot from 2017-08-03 12-34-48

It should be something like this _[screenshot]_
screenshot from 2017-08-03 12-36-36

@amarlearning I prefer the current behaviour - above recipients refers to the To: and the names too, not just the input boxes.

The screenshots that I posted in this comment are from the current behaviour. Either the message should be above recipient or input box but can't both.

I feel the message should span both elements - "distribute 500 points" is related to the input boxes, while "above recipients" is related to the names. It also looks better when it spans both (though I acknowledge that this is subjective).

Spanning both elements seems ok to me too.

Spanning both elements seems ok to me too.

@whipermr5 Shouldn't this be an issue then?

It already spans both.

Not in this case

Sample Image

Is that screenshot the current behaviour on master? How do I reproduce it?

Is that screenshot the current behavior on master?

Yes!

How do I reproduce it?

Look for any Distribute points (among recipients) question in the Student feedback edit page

@amarlearning Could you update the issue description?

@whipermr5 done

I'll try working on this.

While working on this issue, I realised that rank questions have this issue as well:

screen shot 2017-12-21 at 12 29 39 am

Should I raise this as a separate issue, or should I deal with this too along with the constant sum questions? The problems are similar in nature, but the form templates for rank questions and constant sum questions are separate so I'm not too sure.

Should I raise this as a separate issue, or should I deal with this too along with the constant sum questions?

Can fix in the same PR.

Was this page helpful?
0 / 5 - 0 ratings