Teammates: Instructor: download results: multiple repetition of header bug
In CSV results file, header repeats before each row with response instead of appearing only once at the beginning.
LimeTheCoder
All 7 comments
Probably, side-effect of changes introduced in #7555
Working on further investigation
LimeTheCoder
on 8 Jul 2017
@Mynk96 can confirm the bug?
damithc
on 9 Jul 2017
If the bug is confirmed, need to be fixed before next release. Also, how come it is not caught by existing tests?
damithc
on 9 Jul 2017
@damithc @LimeTheCoder Well, the idea was to check each response for comments from the instructor's and add a header correspondingly.
The other approach was to get the maximum number of comments for response and then add a header, but as the screenshot in PR #7711 shows that would have left unnecessary blank cells or a text as "No comment" if there were no comments for a particular response.
Mynk96
on 9 Jul 2017
The other approach was to get the maximum number of comments for response and then add a header, but as the screenshot in PR #7711 shows that would have left unnecessary blank cells or a text as "No comment" if there were no comments for a particular response.
Empty cells is WAY more acceptable than repeating header rows :-p
This behavior is already visible in one of your comments. I should have detected it back then. Sorry about that. Anyway, need to fix before next release.
damithc
on 9 Jul 2017
@Mynk96 @damithc So It's was intended behaviour? Duplicate header before each row of responses is redundant, not obvious for users, time and space consuming and finally makes overall information hardly-readable. I think in that case better to use the second approach with only one header generated according to a maximum number of comments per response. See #7711. I don't think, that rows with blank cells are important in that case. In our results CSV file there many examples of blank cells.
LimeTheCoder
on 9 Jul 2017
@thenaesh This needs to be fixed before V5.109 can be released.
whipermr5
on 10 Jul 2017
Related issues
sujeet14108
路
4Comments
whipermr5
路
4Comments
YongJieYongJie
路
3Comments
whipermr5
路
3Comments
taniach
路
3Comments
Most helpful comment
@Mynk96 @damithc So It's was intended behaviour? Duplicate header before each row of responses is redundant, not obvious for users, time and space consuming and finally makes overall information hardly-readable. I think in that case better to use the second approach with only one header generated according to a maximum number of comments per response. See #7711. I don't think, that rows with blank cells are important in that case. In our results CSV file there many examples of blank cells.