Tdesktop: [Pantheon] No notification numbers in the dock

[png2378]

After update to stable version 0.8.43 notification badges in the dock (Plank) do not displayed.

elementary OS Freya.

[h1royuki]

Same problem.

[auchri]

try update to 0.8.45

[png2378]

@auchri, no, it doesn't solve.

[LukasKalbertodt]

Same here: DockbarX in Ubuntu 14.04 @ Telegram 0.8.45.
Please fix :)

[koshi-dono]

Same problem.

[bilelmoussaoui]

Same here

[auchri]

Is the tray icon visible?

If not, read this: https://github.com/synergy/synergy/issues/4774

[koshi-dono]

Tray icon is visible.

[auchri]

ok, it's possible that this is a bug of elementary os, since it's still in the beta state

[bilelmoussaoui]

elementary is not in a beta state. i had the same issue in Ubuntu Gnome (base on Ubuntu 15.04); to explain the problem
I think that there's some sort of API to send notifications numbers to docks applications in Linux, for example my feed application received unreaded news and show me a notification number like in smartphones ;)

PS : the issue is not in the elemntary tray icon, as this works fine ;)

[LukasKalbertodt]

It's not just about elementary. Something was changed about how notification numbers are reported. Like I said, I use Ubuntu 14.04 and experienced the same with the software dockbarx. Normally it shows notification numbers, like it does with thunderbird:

Sadly after 0.8.43 Telegram doesn't show theses numbers anymore.

Problem is probably somewhere here

[bilelmoussaoui]

And i'm pretty happy to see someone managing the issues here ;)

[auchri]

Hey there!

We're automatically closing this issue since the original poster (or another commenter) hasn't yet responded to the question or request made to them 528 days ago. We therefore assume that the user has lost interest or resolved the problem on their own. Closed issues that remain inactive for a long period may get automatically locked.

Don't worry though; if this is in error, let us know with a comment and we'll be happy to reopen the issue.

Thanks!

_{(Please note that this is an automated comment.)}

[AndydeCleyre]

the original poster (or another commenter) hasn't yet responded to the question or request made to them 528 days ago

I don't think there was a question or request made to the OP.

I am still interested in this. Using latte-dock currently, but it should be the same standard for all the open source docks.

[png2378]

Hey, I'm the OP. This issue is still _very relevant_.

[AndydeCleyre]

@auchri is there a special string your bug-closing bot can pick up on to auto-reopen? Issues shouldn't be closed just because they haven't been addressed, and your bot is closing still-relevant issues left and right.

[john-preston]

@png2378 An API documentation link for dock number setting will help a lot. Without that I don't know what I should try to implement, I don't have all the different DEs and WMs that Linux users have and currently I don't have time to learn them all :(

[bilelmoussaoui]

@john-preston Pantheon isn't using their own API (they don't have one). elementary OS ships the Pantheon desktop, with Plank as a dock application. Which uses Unity(Ubuntu default desktop env) API to show the unread counter(or any counter you would like to show). All you need is to implement libunity API. Here's the documentation link https://wiki.ubuntu.com/Unity/LauncherAPI.
Thanks!

[john-preston]

@bil-elmoussaoui I have a unity counter being set already. And I set it always when I can load the methods from unity library: unity_launcher_entry_get_for_desktop_id, unity_launcher_entry_set_count and unity_launcher_entry_set_count_visible.

[bilelmoussaoui]

@john-preston it's due to this line https://github.com/telegramdesktop/tdesktop/blob/7fb1463c43922b34b696741da536dfafce7a6469/Telegram/SourceFiles/platform/linux/linux_libs.cpp#L274. You just need to check if libunity is installed on the user system, as the user might use Plank which uses Libunity API in any other desktop env(other than Unity)

[auchri]

@AndydeCleyre No, but issues labeled with "enhancement" or "bug " won't be auto closed.
You can submit a PR for my bot: https://github.com/auchri/github_auto_closer

[john-preston]

@bil-elmoussaoui I see. But what if user has libunity because he has unity, but right now he uses some different DE that doesn't use libunity -- and I try to load it and set the counter. Isn't it going to crash or do smth unpredictable? I think it is better to have whitelist of DEs that use libunity for counter display? Or it's fine to always load it?

[bilelmoussaoui]

@john-preston There isn't a list of distro that have libunity by default except Pantheon (elementary OS) and Ubuntu (unity). But in my case for example, i have installed ArchLinux (with Gnome desktop) and compiled libunity from scratch in order to test this issue with Plank. Anyway, if you want me to test a beta version just ping me ;)

[png2378]

In addition to the above, Plank or any other dock with libunity support can be installed on any DE.

[john-preston]

@png2378 So I should call the methods from libunity anyway if I manage to load it and it should not cause any really bad behaviour if current dock / DE / whatever doesn't use it? I'll try in the next build, thanks.

[bilelmoussaoui]

@john-preston it shouldn't cause any harm

[john-preston]

@png2378 @bil-elmoussaoui @AndydeCleyre please check the latest alpha version from https://desktop.telegram.org/changelog#alpha-version I've enabled libunity loading there.

[png2378]

@john-preston latest alpha version works fine for me on Pantheon desktop. Thanks!

[john-preston]

@png2378 @bil-elmoussaoui @AndydeCleyre this change introduced a regression, see #3053, I'll have to make libunity loading conditional once again. Which values of XDG_CURRENT_DESKTOP should I have to load it except "unity"?

[png2378]

@john-preston, as you said in https://github.com/telegramdesktop/tdesktop/issues/3053#issuecomment-282549375, you should add "Pantheon" for fixing this issue on Pantheon Desktop. I don't know other DE (except Unity 7 and Pantheon), using libunity by default.

[bilelmoussaoui]

@john-preston is there a way to check make use of build system to check whether the libunity is found or not ?

[john-preston]

@bil-elmoussaoui The library is loaded only when it is present. The problem that in some cases loading this library (that is there, it is found already) causes the app to crash, just because it is there, but I guess you're not supposed to load it.

[bilelmoussaoui]

Well at least check for Unity or if a list of apps that use the library are found (plank only as far as I know ?)

[john-preston]

@bil-elmoussaoui I checked for Unity before and then I was asked to remove that check because Pantheon displays the counter sent to libunity as well :) So I removed the check. But now I'm returning it back, obviously.

[png2378]

I see commit https://github.com/telegramdesktop/tdesktop/commit/dcd6028e918e8d628eaa836d6f49e0e7564b3f6c and I'm waiting for the next alpha build.

[png2378]

@john-preston, notification badges works for me with latest build (1.0.15) on elementary OS Loki.