Tdesktop: Add option to disable bouncing app icon while receiving notification

[livelazily]

bouncing app icon is so anoying

[auchri]

@telegramdesktop:
https://developer.apple.com/library/mac/documentation/Cocoa/Reference/ApplicationKit/Classes/NSApplication_Class/#reference_container

Methods to Override

Override requestUserAttention: if you want to modify how your app attracts the attention of the user (for example, offering an alternative to the bouncing app icon in the Dock).

See also: cancelUserAttentionRequest

[ryush00]

:+1:

[stek29]

Just comment out psFlash(); and build it
For me notifications are still showing up while app isn't bouncing

[joonaskokko]

This feature would be super awesome. The bouncing is really unnecessary.

[koolkhel]

Yes, it's not quite correct to ignore "Please, do not notify me at all" settings with this bouncing icon. With several multiuser chats it's getting unbearable :-(

[stek29]

@koolkhel wait, icon bounces when notifications are disabled?

[koolkhel]

Yes. All possible notifications (both inside Telegram and in macOS notification center) are disabled yet the icon bounces every received message.

[stek29]

Then it should be a [bug], not an [enhancement] IMO.

[niko-lay]

Confirm, in Telegram Desktop v0.10.19 from Appstore this bug is repeated

[joonas-exove]

Still exists in version 1.0.

[hesna]

please fix this one, it makes the app unusable. the other mac client does not have this problem.

[tulushev]

From macOS Human Interface Guidelines

Use bouncing to notify users of serious information that requires their attention. A bouncing Dock icon is very noticeable, so you should use this method only when the user really needs to know about something. Also, make sure you disable bouncing as soon as the user has addressed the problem.

This bouncing should be deleted entirely, it's violating guidelines(what users expect from UI|UX)

[joonaskokko]

Please do something about this. It's REALLY driving me nuts.

[artyomsadyrin]

I subscribe to all the aforesaid. Developers, please! At least make an option to disable this.
P.S. I love client "Telegram Desktop" more than only macOS-client "Telegram". And it became very important.

[Dabendorf]

I agree with the others. Telegram is a great app, but it is unusable without deactivating that bouncing shit.

[stek29]

I can't reproduce icon bouncing for muted chats.

I like the fact icon bounces tbh. But for anyone who does not, here's the patch: (which you can submit as a PR -- easy pick, hehe)

diff --git a/Telegram/SourceFiles/platform/mac/notifications_manager_mac.mm b/Telegram/SourceFiles/platform/mac/notifications_manager_mac.mm
index c6a61cbac99a..ac7e18a10f12 100644
--- a/Telegram/SourceFiles/platform/mac/notifications_manager_mac.mm
+++ b/Telegram/SourceFiles/platform/mac/notifications_manager_mac.mm
@@ -139,8 +139,7 @@ std::unique_ptr<Window::Notifications::Manager> Create(Window::Notifications::Sy
    return nullptr;
 }

-void FlashBounce() {
-   [NSApp requestUserAttention:NSInformationalRequest];
+inline void FlashBounce() {
 }

 void CustomNotificationShownHook(QWidget *widget) {

[antonakv]

Enjoy
$ defaults write com.apple.dock no-bouncing -bool TRUE

[stek29]

@antonakv I don't want to disable bouncing completely, I just want Telegram to match Apple's guidelines and don't bounce.

[Aokromes]

1184 ?

[laiti]

Please, please fix this one. It is very annoying and not along the Apple guidelines.

[mxs42]

Why this still not a thing?
On Windows it's completely annoying because it triggers taskbar popup.

[reallyuniquename]

Any updates? Flashing taskbar icon is incredibly annoying on Windows.

[mxs42]

@reallyuniquename since devs ignore this for years, I wrote hacky console tool to patch executable and get rid of this stupid flashing.
Check it out, no issues with it if you don't want to maintain your own fork with flashing disabled
https://github.com/mxs42/mutegram

[enricll]

@mxs42 Sorry if it's a stupid question, but I'm very interested in fixing that bug and I don't know how to proceed once I've downloaded your tool. I read the readme but I don't see an executable file inside the folder. Could you tell me the steps in a little bit more of detail? Thanks!

[mxs42]

@enricll download exe from Releases section.

[reallyuniquename]

@mxs42 Incredible job, thank you so much for your universal patch. I've built your tool with VS and successfully patched Telegram binary.

As you can see, there is no way to disable that «flashbounce» without disabling notifications completely.

Is it true though? Even if you completely disable Telegram notifications it still flashes its icon.

In case someone uses old VS version: you have to switch project's toolset to earlier version and add #include <cstdint> line to main.cpp.

[mxs42]

Is it true though? Even if you completely disable Telegram notifications it still flashes its icon.

@reallyuniquename idk, I don't even want to test it again xD
Glad that it helped you.

[AaronMeyers]

well i guess this is never going to get fixed because the devs dgaf, but i would just like to register my opinion: the bouncing dock icon is extremely annoying!

[GuiSim]

What's the reasoning for keeping this? I started using Telegram recently and that's one of the most annoying aspect of the native macos app

[stek29]

@GuiSim fyi there are two telegram apps for macOS, and tdesktop (the one with bouncing icon) isn't the one which is usually referred to as "native". native usually refers to https://macos.telegram.org, not https://desktop.telegram.org.

[Sakari369]

Please disable the bouncing. Modern macOS apps don't really use this bouncing effect anymore. Why be different ? Thank you! It's really annoying.

[asorokoumov]

Please, turn this annoying bouncing off

[oluwasayo]

I've visited this ticket many times and I'm very surprised it's getting no attention from the developers. I'm genuinely interested in knowing why.

[reallyuniquename]

@oluwasayo I am pretty sure this issue is way down the bug queue. Give it few years, build your own version of Telegram client or use external patching tools to remove blinking.

[ihorinki]

Stopped using desktop version because of that.

[antonakv]

$ defaults write com.apple.dock no-bouncing -bool TRUE

[testdevmm]

Have the same problem with version v.2.0.1
I've disabled notifications and counters, but cant disable the bouncing

The Icon bounce if I`m staying in another window/display (even now, when I'm writing this)

Macos version 10.15.3
Telegram version v.2.0.1

[ilya-fedin]

You should disable notifications in _telegram_ settings

[Merlin2001]

On Windows, the taskbar still flashes if notifications are disabled entirely _in Telegram_. So I guess this could be related to the issue on macOS.

[p5ydn0]

So this function is not planned to improve? Telegram is really one of the very few software that still has this annoying function.

[antonakv]

@p5ydn0 There is the same approach as with Helm 3 package manager. They don't care if there is a workaround. The style...

[Husterknupp]

@antonakv @p5ydn0 (and all the others who complain in this thread)

Stop whining. Have you tried writing up a fix and submitting a pull request?

I’m sorry that this app isn’t providing you with the expected value despite all the money that you have paid for being able to use it and have code insights

[p5ydn0]

@antonakv @p5ydn0 (and all the others who complain in this thread)

Stop whining. Have you tried writing up a fix and submitting a pull request?

I’m sorry that this app isn’t providing you with the expected value despite all the money that you have paid for being able to use it and have code insights

Your logic is really strange.

According to what you mean, when anyone who uses a certain software encounters a certain problem or a function they do n’t like, they should shut up and write the code quietly to solve it? So if someone encounters a bug while using the software, and he doesn't program, he can just shut up and suffer?

One reason everyone complains is that we are using this software; since we are using this software, it means that we likes this software at least. Everyone discussing here is also making comments, hoping this software is getting better and better.

It's you, instead, saying something strange and useless.

[mxs42]

@antonakv @p5ydn0 (and all the others who complain in this thread)

Stop whining. Have you tried writing up a fix and submitting a pull request?

I’m sorry that this app isn’t providing you with the expected value despite all the money that you have paid for being able to use it and have code insights

Clueless.
People report a problem with the app, it doesn't make any sense to talk about money in context of this topic.
I didn't pay money to use Telegram but I still can report problems I encountered while using their service.
Telegram is not a someone's personal pet project, it is somewhat bigger and if Telegram want to compete with other solutions they have to take in account what their users say AND users can say whatever they find useful about Telegram, that's how you improve your software.

This issue in particular means that there is a UX problem for some users so they report about it.

For future Windows users reading this topic:
Two years ago I have created a tool to patch Telegram code to get rid of this taskbar flashing, you can find it in this repo https://github.com/mxs42/mutegram

[Aokromes]

@antonakv @p5ydn0 (and all the others who complain in this thread)
Stop whining. Have you tried writing up a fix and submitting a pull request?
I’m sorry that this app isn’t providing you with the expected value despite all the money that you have paid for being able to use it and have code insights

Clueless.
People report a problem with the app, it doesn't make any sense to talk about money in context of this topic.
I didn't pay money to use Telegram but I still can report problems I encountered while using their service.
Telegram is not a someone's personal pet project, it is somewhat bigger and if Telegram want to compete with other solutions they have to take in account what their users say AND users can say whatever they find useful about Telegram, that's how you improve your software.

This issue in particular means that there is a UX problem for some users so they report about it.

For future Windows users reading this topic:
Two years ago I have created a tool to patch Telegram code to get rid of this taskbar flashing, you can find it in this repo mxs42/mutegram

why instead make a tool you don't make a pull request to add the setting

[mxs42]

why instead make a tool you don't make a pull request to add the setting

Because for me it was easier to make a tool and I never worked with QT.

[antonakv]

Yahooo!!!

[nesimtunc]

https://www.macworld.com/article/1138403/dockbounce.html