Tasks: App broken on Nextcloud 12.0.x

[tcitworld]

Steps to reproduce

1. Update app to 0.9.6

Expected behaviour

Good display

Actual behaviour

Display is broken. Browser and server logs don't seem to contain any relevant info, it's just the CSS/JS that's broken.

P.S : Integrity check failure isn't related to this app.

Server configuration

Operating system: Debian

Web server: Nginx

Database: MySQL

PHP version: 7.0

Nextcloud version: (see Nextcloud admin page)12.0.2 (same with 12.0.3)

Tasks version: (see Nextcloud apps page) 0.9.6

Client configuration

Browser: Firefox Nightly, Chromium stable

Operating system: Debian unstable

[raimund-schluessler]

How did you update or install it? I have used and tested it with 12.0.5 and it looks just fine.

[tcitworld]

Through the web updater. It happened on two different instances, so I guess it wasn't an error while updating. Uninstalling and reinstalling didn't fix it.
Unfortunately I won't be able to test the app with these instances on 12.0.5 since I'll upgrade them directly to 13, but I'll try to set up a 12.0.3 instance to have a look.

[raimund-schluessler]

This is weird. It looks as if neither CSS nor JS are loaded at all.

[raimund-schluessler]

Could you check the access rights for the tasks app folder?

[tcitworld]

They seem to be all right.

However, the call to the task app style.css returns an empty file, so I guess that's the issue.

[tcitworld]

In 12.0.3, we don't have those SCSS related PRs : https://github.com/nextcloud/server/pull/7688, https://github.com/nextcloud/server/pull/6661, https://github.com/nextcloud/server/pull/7257

[raimund-schluessler]

In 12.0.3, we don't have those SCSS related PRs : nextcloud/server#7688, nextcloud/server#6661, nextcloud/server#7257

Hm, can we mitigate this within the app? Or does this mean, we cannot use SCSS in < 12.0.5 at all? Maybe @skjnldsv as well.

[raimund-schluessler]

Also, could we set 12.0.5 as minimal version? Or we need to ship the compiled css file??

[skjnldsv]

@raimund-schluessler Nop, scss is active on stable12.

Those prs are for a very specific setup when the user has its app directory outside the nextcloud web directory, so maybe it's relevant for you @tcitworld ? IF so, this is not a tasks related issue :)

[khoebling]

@skjnldsv my apps directory is under the nextcloud web directory and i have the same issues

[skjnldsv]

Any errors in the nextcloud log?

[khoebling]

After manual upgrading from 12.0.0 to 12.0.5 the issues disappeared on chrome. on ie11 it still looks weired

[raimund-schluessler]

IE is a different problem and not supported. On IE there are more problems than just the styling.

Seems like NC12.0.5 is necessary to get rid of SCSS problems.

[skjnldsv]

@raimund-schluessler I'd like to know why though :p

[raimund-schluessler]

@raimund-schluessler I'd like to know why though :p

Yes, that would be good. But I think this is more of a server issue, than an issue of this app.

[skjnldsv]

We need a server log to be sure, but I think too!

[tcitworld]

Unfortunately I didn't see anything relevant inside it.

[skjnldsv]

@tcitworld did you tried clearing your appdata cache?

[tcitworld]

Yeah, deleting appdata_*/css/tasks/* didn't change anything.

[skjnldsv]

Strange. We need to find out what is the issue here.

[raimund-schluessler]

I vaguely remember that I might have experienced something similar, but I don't know anymore exactly how I solved it. Could you try to create the empty folder appdata_*/css/tasks/ with the correct access rights (the same as the other folders in in css, please?

[tcitworld]

It already had fine access rights. However, it seems the folder isn't repopulated since I deleted files inside it.

[skjnldsv]

I will try with a 12.0.5 installation when I have the time! :)

[tcitworld]

As @khoebling said it seems to work with 12.0.5, just not with 12.0.3 and 12.0.2.

[raimund-schluessler]

With 12.0.5 everything worked for me when I tested it. Should we consider this fixed then?

[skjnldsv]

@raimund-schluessler yes, up-to-date versions should be considered as the current supported ones. We need to move forward, we can't patch downward. 👍

[tcitworld]

I have no issues with versions not supported being ignored, but it would be better if the app was marked as incompatible with these versions ;)

[skjnldsv]

@tcitworld but 12.0.5 is supported right? :)

[tcitworld]

Yeah, but we could set min-version="12.0.5" instead of min-version="12" ;)

[skjnldsv]

Does the appinfo parser supports it? :p

[khoebling]

I just went through the logs again, but there were no errors before updating to 12.0.5

[raimund-schluessler]

Does the appinfo parser supports it? :p

If the parser supports that, we will change it accordingly.

[tcitworld]

I think I found the issue : Undefined variable $color-border: line: 242

Line : https://github.com/nextcloud/tasks/blob/master/css/src/nc12.scss#L242

[raimund-schluessler]

I think I found the issue : Undefined variable $color-border: line: 242

Could be, it was added from 12.0.3 (https://github.com/nextcloud/server/blob/v12.0.3/core/css/variables.scss) to 12.0.4 (https://github.com/nextcloud/server/blob/v12.0.4/core/css/variables.scss). Does it work when you add it? We could easily add it to the NC12 scss code then.

[tcitworld]

I tried, unfortunately deleting the files inside appdata_/css/tasks/ and force refreshing or running cron doesn't seem to recreate them. Anyway to clear the SCSS cache properly ?

[skjnldsv]

@tcitworld see rullzer's app for this purpose https://github.com/rullzer/appdatacleaner
Then it's with the occ command line

[tcitworld]

Yup, fixes it. 👍

[raimund-schluessler]

Ok, then I will add this variable to https://github.com/nextcloud/tasks/blob/master/css/src/nc12.scss
@tcitworld Thanks for having a look.

[raimund-schluessler]

Fix is in https://github.com/nextcloud/tasks/pull/147

[raimund-schluessler]

Problem should be fixed now. Would you consider this worth a new release?

[tcitworld]

Well, no one else reported the issue here or on https://help.nextcloud.com so I guess it's fine to wait next release.

[danopz]

Just updated tasks (0.9.6) on my NC12 (<12.0.5) and got the same issue.

[alexgleason]

I'm using Nextcloud 12.0.3 and installed tasks 0.9.6 from the admin UI. I also experienced this issue. I will try updating to Nextcloud 13 later.

[alexgleason]

Ohh, I get it, the fix isn't in the latest release. Yes, if you made a new release that would be helpful! Thank you.

[tcitworld]

Upgrading to 12.0.5 or the latest is far easier ;)

[alexgleason]

I've upgraded to 12.0.5 but still having the issue. I chose not to go with 3.0 because I'm using mailinabox which doesn't support it yet.

[alexgleason]

I'm also happy manually editing the .scss file to make this change, but I'm not sure how to use the above-linked appdatacleaner :confused:

[alexgleason]

I ended up resolving this temporarily by editing /home/user-data/owncloud/appdata_oc258c295b33/css/tasks/fe0c265f6ce379e869cf2ea68e50aa76-style.css, deleting the contents, and pasting the compiled CSS from https://cloud.disroot.org/css/tasks/059001fe-style.css?v=3bd5717d-43, a known working Nextcloud install.

[tcitworld]

@raimund-schluessler Sad to report it's again broken with 0.97 and NC 13.0.5.

[raimund-schluessler]

@raimund-schluessler Sad to report it's again broken with 0.97 and NC 13.0.5.

@tcitworld Could you elaborate a bit on that, please? I don't know, what should have caused that. There were no changes on the scss files which I could imagine doing so: https://github.com/nextcloud/tasks/compare/v0.9.6...v0.9.7