Describe the bug
Download with multiple sheets works fine in 4.4.3 as described in instructions but having trouble in 4.5.2. Download proceeds but only the sheet from the active table shows data on its tab. Looking into code, the problem seems related to download function accepting 5 arguments now but only being provided 4 internally. This results in slight malfunction and data is lost. Example where 4 parameters are provided to 5-argument download function:
Download.prototype.commsReceived = function (table, action, data) {
switch (action) {
case "intercept":
this.download(data.type, "", data.options, data.intercept);
break;
}
};
The intercept function gets lost since the download function expects it to be 5th arg.
Tabulator Info
4.4.3 works, 4.5.2 breaks
Working Example
https://codepen.io/summer-gogeo/pen/oNgZZXQ
To Reproduce
Expected behavior
2 tabs and 2 tables
Desktop (please complete the following information):
OS: CentOS Linuz 7
Browser Chrome
Hey @GoGeophysical
Thanks for the info, i will look into a fix for that for the next patch release.
Cheers
Oli :)
Can repro the same issue.
I have pushed a fix for this to the master branch and will include it in the 4.5.3 patch release.
Cheers
Oli :)
Cool. Thank you. Your Tabulator code is awesome. Summer
4.5.3 is released now :)
Checked 4.5.3 and working as documented now.
Most helpful comment
Cool. Thank you. Your Tabulator code is awesome. Summer