Tabulator: xlsx download with multiple sheet not working properly in version 4.5.2

Created on 19 Dec 2019  路  6Comments  路  Source: olifolkerd/tabulator

Describe the bug
Download with multiple sheets works fine in 4.4.3 as described in instructions but having trouble in 4.5.2. Download proceeds but only the sheet from the active table shows data on its tab. Looking into code, the problem seems related to download function accepting 5 arguments now but only being provided 4 internally. This results in slight malfunction and data is lost. Example where 4 parameters are provided to 5-argument download function:

Download.prototype.commsReceived = function (table, action, data) {
switch (action) {
case "intercept":
this.download(data.type, "", data.options, data.intercept);
break;
}
};

The intercept function gets lost since the download function expects it to be 5th arg.

Tabulator Info
4.4.3 works, 4.5.2 breaks

Working Example
https://codepen.io/summer-gogeo/pen/oNgZZXQ

To Reproduce

  1. Go to 'https://codepen.io/summer-gogeo/pen/oNgZZXQ'
  2. Click on 'Download'
  3. Observe correct 2-tab, 2-table spreadsheet'
  4. Switch Tabulator.js to 4.5.2version listed on codepen example
  5. Observe INcorrect 2-tab, 1-table spreadsheet'

Expected behavior
2 tabs and 2 tables

Desktop (please complete the following information):
OS: CentOS Linuz 7
Browser Chrome

Bug

Most helpful comment

Cool. Thank you. Your Tabulator code is awesome. Summer

All 6 comments

Hey @GoGeophysical

Thanks for the info, i will look into a fix for that for the next patch release.

Cheers

Oli :)

Can repro the same issue.

I have pushed a fix for this to the master branch and will include it in the 4.5.3 patch release.

Cheers

Oli :)

Cool. Thank you. Your Tabulator code is awesome. Summer

4.5.3 is released now :)

Checked 4.5.3 and working as documented now.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Manbec picture Manbec  路  3Comments

sphynx79 picture sphynx79  路  3Comments

mconnelley picture mconnelley  路  3Comments

c3pos-brother picture c3pos-brother  路  3Comments

mohanen picture mohanen  路  3Comments