Synergy-core: Using print screen key also sends alt key

[the-wes]

When using the PrintScreen key via Synergy to capture a screenshot on a Windows client, Synergy always transmits the key as Alt+PrintScreen, which tells Windows to capture only the active application window rather than the full screen.

See this example: http://gfycat.com/PlumpWindyBeaver

[nbolton]

I'm having a title OCD day.

[virtualdxs]

Has this issue been fixed? I see it's still open and the PR hasn't been merged but this hasn't been touched since 12/23/2014.

[themarkwilliams]

Any updates on this. . .would love to see this fixed.

[nlyan]

Should be fixed in v1.8.8-rc1

Give it a go. http://symless.com/nightly?filter=4b913b5

[EvzenP]

Hmmm, I just tried v1.8.8-rc1 and I see no change - still only active window gets printscreened

[Banderi]

Can confirm, the bug is still present.

[EvzenP]

Okay, only now looking through the source code, even with my non-developer limited knowledge I see that the patched piece was definitely not the right place, i.e. this piece of code does not seem to 'convert' the PrintScreen to Alt-PrintScreen.
It's probably somwhere here:
https://github.com/symless/synergy/blob/master/src/lib/platform/MSWindowsKeyState.cpp#L1214
or here:
https://github.com/symless/synergy/blob/master/src/lib/platform/MSWindowsKeyState.cpp#L1250

[yupi2]

I decided to actually get a PR upstream for this here #5885 since I've just been sitting on it for 3 months. Did not intend to submit the PR right now but the Enter button was hit and it was posted... If anyone has a build environment for Windows and wants to test then check it out.

[dmittleider]

I just downloaded 1.9.1 and this is still an issue. Is there a test build where this works at??

[yupi2]

@dmittleider You can see if https://github.com/yupi2/synergy works for you.

[yupi2]

@dmittleider https://github.com/yupi2/synergy/releases/latest

[dmittleider]

I downloaded the pre-compiled one from https://github.com/yupi2/synergy/releases/tag/4.2.0_master_0d1aad0dacc071f9981f778e2ee8a10f36b57ec5 but gives me a Qt error. Are there any other pre-compiled ones for Windows x64?

[yupi2]

@dmittleider See if opening the program again fixes the Qt error but otherwise post an issue on that repo and I'll see about fixing it. There's older versions in the releases tab but you shouldn't use them.

edit:
there's also https://github.com/brahma-dev/synergy-stable-builds with some old versions of Synergy from symless but I don't think they have the printscreen thing fixed & they use old/vulnerable versions of OpenSSL.

[dmittleider]

OK! Perfect, after running it a couple times that went away and the Alt+PrntScrn is now just PrntScrn... I can not tell you how awesome this is. I've used Synergy for years off and on (I come back to it and then get frustrated that doesn't work because my life is doing a ton of documentation and bringing screenshots in). I tried it again here the other day and thought somebody has had to have solved this by now... Thanks!!!

[Banderi]

Is there any way to switch to that version without losing server/client settings? Someone had the bright idea of dropping the config file and moved to registry (Symless whyyyyy), so I had no idea where to look for it and lost all of them.

[yupi2]

@Banderi I didn't like where Synergy stored stuff and wanted certs&configs to be stored in the same directory along with some stuff needing to be changed so it doesn't conflict with Synergy from Symless (registry keys & file paths). It's a pain but if you can find out where SymlessSynergy stores files then you can likely just drop them into one of the following folders (from the changes in the readme):

• Moved configuration files location for no good reason.
  
  
  
  • Windows uses %localappdata%\Synergy\
  
  
  • macOS uses ~/Library/Preferences/Synergy/
  
  
  • Linux/everything-else uses ~/.config/Synergy/
  
  

The Everything program is a good tool for finding files. Searching for Synergy will probably show you all the folders & files related to everything.

My synergy folder looks like this

PS C:\Users\yupi2\AppData\Local\Synergy> tree /F
Folder PATH listing
Volume serial number is ASDF
C:.
│   gui.ini
│
└───SSL
    │   Synergy.pem
    │
    └───Fingerprints
            Local.txt

[Banderi]

I could swear I tried searching for the config files in AppData but I could find nothing. I very much agree the registry is an asinine idea and I totally endorse your decision of using same-folder config files.
That looks like a very neat and useful piece of software though, thanks for sharing that! I'll most certainly be using that in the future.

[themarkwilliams]

What's the resolution of this issue?

Is it fixed? If so, which version contains the fix?

[yupi2]

Works for me with my pull-request here https://github.com/symless/synergy-core/pull/5885
https://github.com/symless/synergy-core/pull/5885.patch
Someone at Symless would just need to review it and apply it.
@nbolton

[nbolton]

@themarkwilliams It was assigned to 1.8.8 but was reopened, so the fix in fact didn't work (and it should never have been assiged to 1.8.8 in the first place). The comments seem to suggest that it is actually not fixed, as commit 3d3b7ca8810f283d2134cdb3fc92b77ef0233c1b wasn't effective.

@yupi2 I'll make a build for your PR (#5885) and post it on this issue to see if it helps.

[hansdg1]

Any progress on this?

[dmittleider]

Any progress on this?

I am still using a @yupi2 build because it doesn't work as of a few days ago when I tried.

[nbolton]

Fixed by #6618