Syndesis: [Conditional flow] Condition manipulation icons are broken

[mcada]

This is a...

[ ] Feature request
[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Documentation issue or request

Description

The behavior is unpredictable:

[gashcrumb]

Um, no there's actually some thought in there. The form requires at least 1 condition, so when you remove all the other ones the trash icon is removed. Also you can't obviously move the first condition up or the last condition down, so those arrows are hidden. The icon placement stays consistent with the arrow direction so that they're arranged in columns.

[gashcrumb]

@dongniwang I could probably be convinced to set these buttons to disabled vs hiding 'em, think that'd be a better option?

[dongniwang]

Yeah, I was going to suggest that we just disabled those icons.

[mcada]

Um, no there's actually some thought in there. The form requires at least 1 condition, so when you remove all the other ones the trash icon is removed. Also you can't obviously move the first condition up or the last condition down, so those arrows are hidden. The icon placement stays consistent with the arrow direction so that they're arranged in columns.

@gashcrumb I do not know what you are talking about, the issue is not about the icons but the functionality:

First gif: I can not move second condition up.
Second gif: deleting the first condition deletes the second one.
Third gif: moving the condition copies the value to another condition.

[gashcrumb]

Ah, I see. A caption on the gifs would have been helpful to understand what I'm looking at :laughing:

[mcada]

My bad, will do next time :)

[gashcrumb]

hmm, yeah I think the main problem is that this occurs when you use the buttons before actually entering things into the field. So probably I just need to revisit what's going on when a new entry is added to the array.

[gashcrumb]

Assuming the p0 label was taken off in error :smile:

[mcada]

All 3 scenarios are still broken, tested on syndesis 7226de41a84b7ed37e9717fa7e0bd75eec6cdaf0

[mastepan]

@mcada @gashcrumb just checking. Is there anything that should be checked by QE?

[mcada]

@mastepan there is automated test for this use-case, please run it against current syndesis master just to be sure that it works